Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MenuButton): call onMenuHide on all cases where menu is closed #2027

Merged
merged 1 commit into from
Mar 20, 2024
Merged

fix(MenuButton): call onMenuHide on all cases where menu is closed #2027

merged 1 commit into from
Mar 20, 2024

Conversation

YossiSaadi
Copy link
Contributor

@YossiSaadi YossiSaadi requested a review from a team as a code owner March 19, 2024 11:17
@YossiSaadi YossiSaadi marked this pull request as draft March 19, 2024 11:18
@YossiSaadi YossiSaadi force-pushed the fix/yossi/MenuButton---applying-closeMenuOnItemClick-prevents-from-onMenuHide-from-being-called-6285146715 branch from 6a625c9 to 9ac1e7f Compare March 19, 2024 11:58
@YossiSaadi YossiSaadi force-pushed the fix/yossi/MenuButton---applying-closeMenuOnItemClick-prevents-from-onMenuHide-from-being-called-6285146715 branch from 9ac1e7f to 943ffd0 Compare March 19, 2024 14:07
@github-actions GitHub Actions
Copy link
Contributor

A new prerelease version of this PR has been published! 🎉
To install this prerelease version, run the following command in your terminal with any one of the packages changed in this PR:

To update monday-ui-react-core:

yarn add monday-ui-react-core@2.98.1-fixyossimenubuttonapplyingclosemenuonitemclickpreventsfromonmenuhidefrombeingcalled6285146715.0

Or with npm:

npm i monday-ui-react-core@2.98.1-fixyossimenubuttonapplyingclosemenuonitemclickpreventsfromonmenuhidefrombeingcalled6285146715.0

@YossiSaadi YossiSaadi marked this pull request as ready for review March 20, 2024 09:53
@YossiSaadi YossiSaadi merged commit 1c80b4c into master Mar 20, 2024
10 checks passed
@YossiSaadi YossiSaadi deleted the fix/yossi/MenuButton---applying-closeMenuOnItemClick-prevents-from-onMenuHide-from-being-called-6285146715 branch March 20, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaharzil shaharzil shaharzil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YossiSaadi @shaharzil