Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: repo renaming announcement #2018

Merged
merged 1 commit into from
Mar 18, 2024
Merged

docs: repo renaming announcement #2018

merged 1 commit into from
Mar 18, 2024

Conversation

talkor
Copy link
Member

@talkor talkor commented Mar 17, 2024

Screenshot 2024-03-17 at 18 09 48

@talkor talkor requested a review from a team as a code owner March 17, 2024 16:09
Copy link
Contributor

@YossiSaadi YossiSaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to attach this change to Vibe 3.0? or to the packages change to @vibe?

also, we should create a task to change the repo in the package.json and change monday's documentations that refers to monday-ui-react-core

additionally, it's worth checking if github has a feature to redirect for a period of time the old url to the new one

[![npm](https://img.shields.io/npm/v/monday-ui-react-core)](https://www.npmjs.com/package/monday-ui-react-core)

![image](https://user-images.githubusercontent.com/60314759/147566893-63c5209a-8b83-4f32-af61-8b4c350ec770.png)
<img src="https://user-images.githubusercontent.com/60314759/147566893-63c5209a-8b83-4f32-af61-8b4c350ec770.png" width="300px" alt="Vibe Design System, by monday.com">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to do it for century, lol 😂

@talkor
Copy link
Member Author

talkor commented Mar 17, 2024

Don't we want to attach this change to Vibe 3.0? or to the packages change to @vibe?

also, we should create a task to change the repo in the package.json and change monday's documentations that refers to monday-ui-react-core

additionally, it's worth checking if github has a feature to redirect for a period of time the old url to the new one

It's not a breaking change but we can consider introducing it in Vibe 3.0, even though it's not a versioned changed, only a rename of the repo. Let's talk about it.

We have a different task to rename all the meta around the name change, once we're ready to do that, but I think it's important to announce the renaming beforehand as early as possible.

Github does take care of renaming and redirects - see this for example

@talkor talkor merged commit aafef16 into master Mar 18, 2024
6 checks passed
@talkor talkor deleted the docs/renaming-announcement branch March 18, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants