feat(ModalFooterButtons): support disable buttons and remove secondary #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YossiSaadi
reviewed
Mar 13, 2024
There was a problem hiding this comment.
Seems cool by me 💪🏼
@talkor I was wondering if we should allow passing all props for each of the button
wdyt? should we consult design about it? as it is abusable
talkor
requested changes
Mar 13, 2024
packages/core/src/components/Modal/ModalFooter/ModalFooterButtons/ModalFooterButtons.tsx
Outdated
Show resolved
Hide resolved
Yes it was the thought at first but designers don't want to give this flexibility for now |
talkor
approved these changes
Mar 13, 2024
| }); | ||
| fireEvent.click(modalFooterComponent.getByText(PRIMARY_BUTTON_TEXT)); | ||
| expect(onPrimaryButtonClick).not.toBeCalled(); | ||
| expect(onSecondaryButtonClick).not.toBeCalled(); |
There was a problem hiding this comment.
this is a test to validate that the button is indeed disabled
There was a problem hiding this comment.
I mean just this line, there's nothing going on with the secondary button in this test, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic
npm run plop) to create a new component.Style
NewComponent.modules.scssfile inside theNewComponentfolder.Storybook
/src/components/NewComponent/__stories__/NewComponent.mdxfile.Tests
Accessibility