Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Align vibe's colors to new a11y based colors #2009

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

MBYOded
Copy link
Contributor

@MBYOded MBYOded commented Mar 12, 2024

As part of Monday's effort to make our customers experience as accessible as possible we've decided to update some of our colors to be AAA accessible and empower our costumers with sight impairment with a better more suitable experience.

https://monday.monday.com/docs/5264487294

@MBYOded MBYOded requested a review from a team as a code owner March 12, 2024 00:06
@MBYOded MBYOded changed the title Align vibe's colors to new a11y based colors [refactor] Align vibe's colors to new a11y based colors Mar 12, 2024
@MBYOded MBYOded changed the title [refactor] Align vibe's colors to new a11y based colors refactor - Align vibe's colors to new a11y based colors Mar 12, 2024
@MBYOded MBYOded changed the title refactor - Align vibe's colors to new a11y based colors refactor: Align vibe's colors to new a11y based colors Mar 12, 2024
@YossiSaadi
Copy link
Contributor

Hey @MBYOded ! long time :)
seems cool, but just to make sure - those changes were approved/requested by Vibe designers?

@MBYOded
Copy link
Contributor Author

MBYOded commented Mar 12, 2024

Hey @MBYOded ! long time :) seems cool, but just to make sure - those changes were approved/requested by Vibe designers?

@YossiSaadi my man,
Sure thing, Meirav asked me to change here as well.
We're doing a A11y change that affects most of our code base and we needed to reflect it here as well

Copy link
Contributor

@YossiSaadi YossiSaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@YossiSaadi
Copy link
Contributor

Hey @MBYOded ! long time :) seems cool, but just to make sure - those changes were approved/requested by Vibe designers?

@YossiSaadi my man, Sure thing, Meirav asked me to change here as well. We're doing a A11y change that affects most of our code base and we needed to reflect it here as well

Bless you 🙏🏼

@talkor talkor changed the title refactor: Align vibe's colors to new a11y based colors feat: Align vibe's colors to new a11y based colors Mar 12, 2024
@talkor
Copy link
Member

talkor commented Mar 12, 2024

@MBYOded you need to also change the colors in the theme sass files (packages/style/src/Themes)

@MBYOded MBYOded merged commit 6c6e156 into master Mar 13, 2024
8 checks passed
@MBYOded MBYOded deleted the odedbe/feature/accessible_colors_alignment branch March 13, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants