-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate Dropdown to TS #1976
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Mila2999! That's really great. Let's just avoid using any
and leverage TS and use the actual types
thanks @talkor, i will work on fixing the types |
Hi @talkor , i removed all any references except |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking the time to work on this! And apologies for the long delay. I wrote some comments and some notes to make this migration without breaking existing usages
Thanks!
Hi @talkor , thank you for your time in reviewing my PR. I have addressed your comments and made the necessary fixes to the code |
@talkor i reverted react-windowed-select from 3.1.0 back to "^2.0.4". to fix typescript errors i added a file and declared a module there, this fixed errors in vs code for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You did amazing @Mila2999 !
Thank you! 🙏🏼
I went through mainly on the props, will go through the rest of stuff in another iteration
Hi @YossiSaadi, Thank you! I appreciate the feedback. I have rebased my code onto the master branch and resolved the conflicts in the latest commit. Sorry for any delays, as I'm currently on vacation, but I really would like to finalize this issue. |
@Mila2999 thank you so much for the time you put into it! We really appreciate it! 🙏🏼 |
fixes #1622
Basic
npm run plop
) to create a new component.Style
NewComponent.modules.scss
file inside theNewComponent
folder.Storybook
/src/components/NewComponent/__stories__/NewComponent.mdx
file.Tests
Accessibility