feat(Table): new sort behavior #1935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YossiSaadi
force-pushed
the
feat/yossi/Table---New-sort-behavior-5898339907
branch
from
a3c64e7 to
292b18a
Compare
|
Not ready yet - design wants extra UX functionalities |
YossiSaadi
changed the title
YossiSaadi
force-pushed
the
feat/yossi/Table---New-sort-behavior-5898339907
branch
from
fe9ac86 to
0d4ccf7
Compare
…l hover with mouse
YossiSaadi
force-pushed
the
feat/yossi/Table---New-sort-behavior-5898339907
branch
from
0d4ccf7 to
9d5ed1e
Compare
…39907 # Conflicts: # packages/core/src/components/Table/TableHeaderCell/TableHeaderCell.module.scss
YossiSaadi
force-pushed
the
feat/yossi/Table---New-sort-behavior-5898339907
branch
from
621e496 to
5828ee9
Compare
talkor
approved these changes
Mar 6, 2024
| cleanup(); | ||
| const { getByText } = renderComponent({ onBlur, blurOnMouseUp: false }); | ||
| const { getByText } = render( | ||
| <Button onBlur={onBlur} blurOnMouseUp={false}> |
There was a problem hiding this comment.
I didn't even notice that we have this prop
Comment on lines
+57
to
+58
| aria-sort={onSortClicked ? ariaSort : undefined} | ||
| tabIndex={onSortClicked ? 0 : undefined} |
There was a problem hiding this comment.
on purpose, since I do not want the prop to be defined, it is the same as we're not passing a prop at all
for aria-sort for example, I do not want to show aria-sort in the DOM since a screen-reader can think it is sortable
for tabIndex, null is not a correct value, and I want to use the default
…led (solves a11y issue) (#1994)
Co-authored-by: Tal Koren <[email protected]>
YossiSaadi
force-pushed
the
feat/yossi/Table---New-sort-behavior-5898339907
branch
from
bc04a4a to
fc1b36b
Compare
…idden when onClick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/3532714909/pulses/5898339907