feat(Modal): change context value of contentScrolled to isContentScro…

…lled per to CR request
mondaycom · Oct 20, 2024 · ebcf078 · ebcf078
1 parent 5819126
commit ebcf078
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/packages/core/src/components/ModalNew/ModalContent/__tests__/ModalContent.test.tsx b/packages/core/src/components/ModalNew/ModalContent/__tests__/ModalContent.test.tsx
@@ -15,7 +15,7 @@ describe("ModalContent", () => {
     modalId: "modal-id",
     setTitleId: jest.fn(),
     setDescriptionId: jest.fn(),
-    contentScrolled: false,
+    isContentScrolled: false,
     setContentScrolled: jest.fn()
   };
 

diff --git a/packages/core/src/components/ModalNew/ModalHeader/__tests__/ModalHeader.test.tsx b/packages/core/src/components/ModalNew/ModalHeader/__tests__/ModalHeader.test.tsx
@@ -18,7 +18,7 @@ describe("ModalHeader", () => {
     modalId: "modal-id",
     setTitleId: jest.fn(),
     setDescriptionId: jest.fn(),
-    contentScrolled: false,
+    isContentScrolled: false,
     setContentScrolled: jest.fn()
   };
 

diff --git a/packages/core/src/components/ModalNew/context/ModalContext.tsx b/packages/core/src/components/ModalNew/context/ModalContext.tsx
@@ -4,15 +4,15 @@ import { ModalContextProps, ModalProviderProps } from "./ModalContext.types";
 const ModalContext = createContext<ModalContextProps | undefined>(undefined);
 
 export const ModalProvider = ({ value, children }: ModalProviderProps) => {
-  const [contentScrolled, setContentScrolled] = useState<boolean>(false);
+  const [isContentScrolled, setContentScrolled] = useState<boolean>(false);
 
   const contextValue = useMemo<ModalContextProps>(
     () => ({
       ...value,
-      contentScrolled,
+      isContentScrolled,
       setContentScrolled: (newContentScrolled: boolean) => setContentScrolled(newContentScrolled)
     }),
-    [contentScrolled, value]
+    [isContentScrolled, value]
   );
 
   return <ModalContext.Provider value={contextValue}>{children}</ModalContext.Provider>;

diff --git a/packages/core/src/components/ModalNew/context/ModalContext.types.ts b/packages/core/src/components/ModalNew/context/ModalContext.types.ts
@@ -1,7 +1,7 @@
 import React from "react";
 
 export interface ModalContextProps extends ModalProviderValue {
-  contentScrolled: boolean;
+  isContentScrolled: boolean;
   setContentScrolled: (scrolled: boolean) => void;
 }
 

diff --git a/packages/core/src/components/ModalNew/layouts/ModalBasicLayout/ModalBasicLayout.tsx b/packages/core/src/components/ModalNew/layouts/ModalBasicLayout/ModalBasicLayout.tsx
@@ -14,7 +14,7 @@ const ModalBasicLayout = forwardRef(
     ref: React.ForwardedRef<HTMLDivElement>
   ) => {
     const [header, content] = React.Children.toArray(children);
-    const { contentScrolled } = useModal();
+    const { isContentScrolled } = useModal();
 
     return (
       <Flex
@@ -26,7 +26,7 @@ const ModalBasicLayout = forwardRef(
         data-testid={dataTestId || getTestId(ComponentDefaultTestId.MODAL_NEXT_BASIC_LAYOUT, id)}
       >
         <div className={styles.header}>{header}</div>
-        {contentScrolled && <Divider className={styles.divider} withoutMargin />}
+        {isContentScrolled && <Divider className={styles.divider} withoutMargin />}
         <div className={styles.content}>{content}</div>
       </Flex>
     );