fix(useSwitch): type guard to fix breaking change we accidentally int…

…roduced in previous version (#2330)
mondaycom · Aug 6, 2024 · d07d907 · d07d907
1 parent 780fdf7
commit d07d907
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/packages/core/src/hooks/useSwitch/__tests__/useSwitch.test.ts b/packages/core/src/hooks/useSwitch/__tests__/useSwitch.test.ts
@@ -71,7 +71,7 @@ describe("useSwitch", () => {
       const { result } = renderHookForTest({ defaultChecked: true, onChange });
       callOnChange(result);
       expect(onChange).toBeCalledTimes(1);
-      expect(onChange).toBeCalledWith(false, expect.anything());
+      expect(onChange).toBeCalledWith(false);
     });
   });
 

diff --git a/packages/core/src/hooks/useSwitch/index.ts b/packages/core/src/hooks/useSwitch/index.ts
@@ -8,7 +8,7 @@ enum SwitchRole {
 export interface UseSwitchProps {
   isChecked?: boolean;
   defaultChecked?: boolean;
-  onChange?: (value: boolean, event?: ChangeEvent<HTMLInputElement>) => void;
+  onChange?: (value: boolean, event?: ChangeEvent<HTMLInputElement> | any) => void;
   isDisabled?: boolean;
 }
 
@@ -18,15 +18,21 @@ export default function useSwitch({ isChecked, defaultChecked, onChange, isDisab
   const [overrideChecked, setOverrideChecked] = useState(overrideCheckedInitial);
 
   const overrideOnChange = useCallback(
-    (event?: ChangeEvent<HTMLInputElement>) => {
+    // TODO fix in next major. We need to remove any type
+    (event?: ChangeEvent<HTMLInputElement> | any) => {
       if (isDisabled) {
         return;
       }
       const newChecked = !overrideChecked;
       if (isChecked === undefined) {
         setOverrideChecked(newChecked);
       }
-      onChange && onChange(newChecked, event);
+      // TODO fix in next major. We should always pass the event
+      if (event && typeof event === "object" && "target" in event) {
+        onChange?.(newChecked, event);
+      } else {
+        onChange?.(newChecked);
+      }
     },
     [isChecked, isDisabled, onChange, overrideChecked]
   );