-
Notifications
You must be signed in to change notification settings - Fork 321
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(withLiveEdit): parse render attribute with ast instead of with r…
…egex for variety of cases (#2078)
- Loading branch information
1 parent
6b1e520
commit 57ad30d
Showing
5 changed files
with
122 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90 changes: 90 additions & 0 deletions
90
packages/core/src/storybook/decorators/withLiveEdit/utils/parse-csf-utils.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| import { transformFromAst } from "@babel/standalone"; | ||
| import { parse } from "@babel/parser"; | ||
| import { | ||
| File, | ||
| Program, | ||
| Expression, | ||
| Statement, | ||
| ObjectProperty, | ||
| FunctionExpression, | ||
| ArrowFunctionExpression, | ||
| isObjectExpression, | ||
| isBlockStatement, | ||
| isExpressionStatement, | ||
| isObjectProperty, | ||
| isIdentifier, | ||
| isArrowFunctionExpression, | ||
| isFunctionExpression | ||
| } from "@babel/types"; | ||
|
|
||
| const parseCsfToAst = (csfString: string) => { | ||
| return parse(csfString, { | ||
| plugins: ["typescript", "jsx"], | ||
| sourceType: "module" | ||
| }); | ||
| }; | ||
|
|
||
| function findRenderProperty(body: Statement[]): ObjectProperty { | ||
| return body | ||
| .flatMap(node => | ||
| isExpressionStatement(node) && isObjectExpression(node.expression) ? node.expression.properties : [] | ||
| ) | ||
| .find(prop => isObjectProperty(prop) && isIdentifier(prop.key) && prop.key.name === "render") as ObjectProperty; | ||
| } | ||
|
|
||
| function prepareTransformTarget(renderProperty: ObjectProperty): Program { | ||
| const { value } = renderProperty; | ||
| const isFunction = isFunctionExpression(value) || isArrowFunctionExpression(value); | ||
| if (!isFunction) { | ||
| // e.g. render: something | ||
| const expression = value as Expression; | ||
| return { | ||
| type: "Program", | ||
| body: [{ type: "ExpressionStatement", expression }], | ||
| directives: [], | ||
| sourceType: "module" | ||
| }; | ||
| } | ||
|
|
||
| // e.g. render: () => {...}, render: () => (...), render() | ||
| const { body } = value as FunctionExpression | ArrowFunctionExpression; | ||
|
|
||
| return { | ||
| type: "Program", | ||
| body: [ | ||
| { | ||
| type: "ExpressionStatement", | ||
| expression: isBlockStatement(body) ? value : body | ||
| } | ||
| ], | ||
| directives: [], | ||
| sourceType: "module" | ||
| }; | ||
| } | ||
|
|
||
| function transformAstToCode(ast: File): string { | ||
| // docs says transformFromAst is void, but it is not because of a breaking change | ||
| const { code } = transformFromAst(ast, null, { presets: [] }) as unknown as { code: string }; | ||
| return code; | ||
| } | ||
|
|
||
| export function extractRenderAttributeFromCsf(csfString: string) { | ||
| const originalAst = parseCsfToAst(csfString); | ||
|
|
||
| const renderProperty = findRenderProperty(originalAst.program.body); | ||
| if (!renderProperty) { | ||
| return null; | ||
| } | ||
|
|
||
| const transformTarget = prepareTransformTarget(renderProperty); | ||
| if (!transformTarget) { | ||
| return null; | ||
| } | ||
|
|
||
| const transformedAst: File = { | ||
| type: "File", | ||
| program: transformTarget | ||
| }; | ||
|
|
||
| return transformAstToCode(transformedAst); | ||
| } |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters