chore: change hideWhenReferenceHidden default to true

mondaycom · Sep 3, 2024 · 5622aa6 · 5622aa6
1 parent 2da23ce
commit 5622aa6
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 10 deletions.
diff --git a/packages/core/src/components/Slider/__tests__/__snapshots__/Slider-non-ranged.test.js.snap b/packages/core/src/components/Slider/__tests__/__snapshots__/Slider-non-ranged.test.js.snap
@@ -49,6 +49,7 @@ Snapshot Diff:
         />
 +       <span
 +         class="monday-style-dialog-content-wrapper contentWrapper"
++         data-popper-reference-hidden="false"
 +         data-testid="tooltip"
 +         style="position: absolute; left: 0px; top: 0px;"
 +       >
@@ -87,6 +88,7 @@ Snapshot Diff:
         />
 -       <span
 -         class="monday-style-dialog-content-wrapper contentWrapper"
+-         data-popper-reference-hidden="false"
 -         data-testid="tooltip"
 -         style="position: absolute; left: 0px; top: 0px;"
 -       >
@@ -125,6 +127,7 @@ Snapshot Diff:
         />
 +       <span
 +         class="monday-style-dialog-content-wrapper contentWrapper"
++         data-popper-reference-hidden="false"
 +         data-testid="tooltip"
 +         style="position: absolute; left: 0px; top: 0px;"
 +       >
@@ -163,6 +166,7 @@ Snapshot Diff:
         />
 -       <span
 -         class="monday-style-dialog-content-wrapper contentWrapper"
+-         data-popper-reference-hidden="false"
 -         data-testid="tooltip"
 -         style="position: absolute; left: 0px; top: 0px;"
 -       >

diff --git a/packages/core/src/components/Slider/__tests__/__snapshots__/Slider-ranged.test.js.snap b/packages/core/src/components/Slider/__tests__/__snapshots__/Slider-ranged.test.js.snap
@@ -60,6 +60,7 @@ Snapshot Diff:
         />
 +       <span
 +         class="monday-style-dialog-content-wrapper contentWrapper"
++         data-popper-reference-hidden="false"
 +         data-testid="tooltip"
 +         style="position: absolute; left: 0px; top: 0px;"
 +       >
@@ -98,6 +99,7 @@ Snapshot Diff:
         />
 +       <span
 +         class="monday-style-dialog-content-wrapper contentWrapper"
++         data-popper-reference-hidden="false"
 +         data-testid="tooltip"
 +         style="position: absolute; left: 0px; top: 0px;"
 +       >
@@ -136,6 +138,7 @@ Snapshot Diff:
         />
 -       <span
 -         class="monday-style-dialog-content-wrapper contentWrapper"
+-         data-popper-reference-hidden="false"
 -         data-testid="tooltip"
 -         style="position: absolute; left: 0px; top: 0px;"
 -       >
@@ -174,6 +177,7 @@ Snapshot Diff:
         />
 +       <span
 +         class="monday-style-dialog-content-wrapper contentWrapper"
++         data-popper-reference-hidden="false"
 +         data-testid="tooltip"
 +         style="position: absolute; left: 0px; top: 0px;"
 +       >
@@ -284,9 +288,10 @@ Snapshot Diff:
           role="slider"
           style="left: 65%;"
           tabindex="0"
--       />
+        />
 -       <span
 -         class="monday-style-dialog-content-wrapper contentWrapper"
+-         data-popper-reference-hidden="false"
 -         data-testid="tooltip"
 -         style="position: absolute; left: 0px; top: 0px;"
 -       >
@@ -306,7 +311,7 @@ Snapshot Diff:
 -             class="arrow arrow dark"
 -             data-placement="top"
 -             style="position: absolute;"
-        />
+-           />
 -         </div>
 -       </span>
       </div>

diff --git a/packages/core/src/components/Tipseen/Tipseen.tsx b/packages/core/src/components/Tipseen/Tipseen.tsx
@@ -96,7 +96,7 @@ const Tipseen: VibeComponent<TipseenProps> & {
       showTrigger = [],
       width,
       moveBy,
-      hideWhenReferenceHidden = true,
+      hideWhenReferenceHidden = false,
       tip = true,
       tooltipArrowClassName,
       modifiers = [],

diff --git a/packages/core/src/components/Tipseen/__tests__/__snapshots__/Tipseen.test.tsx.snap b/packages/core/src/components/Tipseen/__tests__/__snapshots__/Tipseen.test.tsx.snap
@@ -82,7 +82,7 @@ exports[`Snapshot tests Tipseen tests renders correctly with dark close button t
   />
   <span
     class="monday-style-dialog-content-wrapper contentWrapper"
-    data-popper-reference-hidden="true"
+    data-popper-reference-hidden="false"
     data-testid="tooltip"
     style="position: absolute; left: 0px; top: 0px; transform: translate(0px, 4px);"
   >
@@ -149,6 +149,7 @@ exports[`Snapshot tests Tipseen tests renders correctly with dark close button t
 exports[`Snapshot tests Tipseen tests renders correctly with floating variation 1`] = `
 <span
   class="monday-style-dialog-content-wrapper contentWrapper"
+  data-popper-reference-hidden="false"
   data-testid="tooltip"
   style="position: absolute; left: 0px; top: 0px;"
 >
@@ -213,6 +214,7 @@ exports[`Snapshot tests Tipseen tests renders correctly without close 1`] = `
   />
   <span
     class="monday-style-dialog-content-wrapper contentWrapper"
+    data-popper-reference-hidden="false"
     data-testid="tooltip"
     style="position: absolute; left: 0px; top: 0px;"
   >

diff --git a/packages/core/src/components/Tooltip/Tooltip.tsx b/packages/core/src/components/Tooltip/Tooltip.tsx
@@ -155,7 +155,7 @@ export default class Tooltip extends PureComponent<TooltipProps> {
     withoutDialog: false,
     containerSelector: "#tooltips-container",
     tip: true,
-    hideWhenReferenceHidden: true,
+    hideWhenReferenceHidden: false,
     modifiers: new Array<Modifier<unknown>>(),
     showTrigger: Tooltip.hideShowTriggers.MOUSE_ENTER,
     hideTrigger: Tooltip.hideShowTriggers.MOUSE_LEAVE,

diff --git a/packages/core/src/components/Tooltip/__tests__/__snapshots__/Tooltip.snapshot.test.tsx.snap b/packages/core/src/components/Tooltip/__tests__/__snapshots__/Tooltip.snapshot.test.tsx.snap
@@ -15,7 +15,7 @@ exports[`Tooltip renders correctly with data-testid 1`] = `
   />,
   <span
     className="monday-style-dialog-content-wrapper contentWrapper"
-    data-popper-reference-hidden={null}
+    data-popper-reference-hidden={false}
     data-testid="test"
     onClickCapture={[Function]}
     style={
@@ -127,7 +127,7 @@ exports[`Tooltip renders correctly with position 1`] = `
   />,
   <span
     className="monday-style-dialog-content-wrapper contentWrapper"
-    data-popper-reference-hidden={null}
+    data-popper-reference-hidden={false}
     data-testid="tooltip"
     onClickCapture={[Function]}
     style={
@@ -183,7 +183,7 @@ exports[`Tooltip renders correctly with style 1`] = `
   />,
   <span
     className="monday-style-dialog-content-wrapper contentWrapper"
-    data-popper-reference-hidden={null}
+    data-popper-reference-hidden={false}
     data-testid="tooltip"
     onClickCapture={[Function]}
     style={
@@ -244,7 +244,7 @@ exports[`Tooltip renders correctly with theme 1`] = `
   />,
   <span
     className="monday-style-dialog-content-wrapper contentWrapper"
-    data-popper-reference-hidden={null}
+    data-popper-reference-hidden={false}
     data-testid="tooltip"
     onClickCapture={[Function]}
     style={
@@ -312,7 +312,7 @@ exports[`Tooltip renders correctly without arrow 1`] = `
   />,
   <span
     className="monday-style-dialog-content-wrapper contentWrapper"
-    data-popper-reference-hidden={null}
+    data-popper-reference-hidden={false}
     data-testid="tooltip"
     onClickCapture={[Function]}
     style={