Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple file IO from commands in CLI #305

Closed
caufieldjh opened this issue Jan 3, 2024 · 1 comment
Closed

Decouple file IO from commands in CLI #305

caufieldjh opened this issue Jan 3, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@caufieldjh
Copy link
Member

This came up in discussion of #279.
CLI commands currently parse the template name and take that as a file location, but in practice it may be more helpful to have them accept a pre-parsed object in a process parallel to that of writing (e.g., the output could be YAML or HTML or whatever, but we don't handle that in the command).
This would make it easier for pre- and post-processing functions to know which template is currently being used since it will already be loaded, rather than isolated to a single CLI command.

@caufieldjh caufieldjh added the enhancement New feature or request label Jan 3, 2024
caufieldjh added a commit that referenced this issue Jan 16, 2024
or rather, don't use different Engines for different sources, like
GPT4All.

Also address #305 - this is a bit overloaded for a single PR but will be
messy to handle concurrently.

Support for loading local models will be in a different PR.
@caufieldjh
Copy link
Member Author

Addresses in #306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant