Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directly call *env commands to avoid hook path duplication #25

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

jmcantrell
Copy link
Contributor

I noticed that any time I use *env latest install, any after_install hooks were being called twice.

Eventually, I found that this (would apply to any $COMMAND, but I'm using luaenv as an example) in combination with the fact that xxenv-latest is calling the install commands like $COMMAND install is causing the hook directories to be added twice. The first time, when *env latest ... is called by the user and then again when xxenv-latest calls the install command.

Since *env sets up PATH such that the subcommands can be used directly, it makes more sense to call them like $COMMAND-$SUBCOMMAND. This ensures the hook PATH is only altered once.

I went ahead and changed every call (not just install) to be consistent, but I don't know that it would affect others, since {before,after}_install seem to be the only hooks. There could be more in the future, and this would ensure all the commands have a clean environment.

Kind of related, but would you be open to me adding some unit testing in another PR?

@jmcantrell
Copy link
Contributor Author

I should have created a different branch for the other nitpicky stuff. Would you prefer if I closed this and reworked it?

@momo-lab
Copy link
Owner

It's no problem as it is. However, please give me time to verify the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants