Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to smooth out shadows #88

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Mac-tf2
Copy link
Member

@Mac-tf2 Mac-tf2 commented Aug 28, 2024

Dark shadows look terrible when converted, so I've added an option to fix that. Changing the value of smoothshadows multiplies the lightmap brightness by that number, and makes every lightmapped texture darker by the same amount to compensate for the now brighter shadows.

Before
chaos_WOy3TO3SwD

After
chaos_fr2r4tl6k7

@Panzerhandschuh
Copy link
Member

I wonder if there is an automatic way to properly convert the brightness. Maybe check for compile flags in the entity lump to see if there is something that modifies lightmap brightness/smoothness?

@Mac-tf2
Copy link
Member Author

Mac-tf2 commented Aug 31, 2024

Looking a little more at the problem I think the faces are just too bright by default. mat_fullbright 1 is so much brighter than it should be on world brushes. The darker func_brush faces is how they are supposed to look I'm pretty sure, since those look normal with fullbright on. Hold off on this for now in case a simpler fix is possible in the face lump data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants