Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add better logging for dictionary tests #569

Merged
merged 1 commit into from
Sep 6, 2024
Merged

chore: add better logging for dictionary tests #569

merged 1 commit into from
Sep 6, 2024

Conversation

rishtigupta
Copy link
Contributor

PR Description:

The test now outputs the actual keys and values stored in the dictionary like below example:

Hit Response Dictionary Contents:
Key: 60-7E-FC-0E-86-2F-C8-4D-AE-BD-1B-18-FB-1C-18-CE | Value: 87-4C-1A-5B-61-2A-DA-47-A4-26-3A-F3-40-65-68-55
Key: 9F-24-B9-EB-39-84-B4-43-A4-23-75-B4-DF-0C-54-CE | Value: 61-53-2C-CD-04-4D-56-49-8D-73-7D-33-B2-A6-A6-88

@rishtigupta rishtigupta marked this pull request as ready for review September 6, 2024 00:48
@rishtigupta rishtigupta force-pushed the chore/better-logging-dictionary-tests branch from 904e4d8 to e8f7479 Compare September 6, 2024 00:54
@rishtigupta rishtigupta merged commit 3945a8c into main Sep 6, 2024
8 checks passed
@rishtigupta rishtigupta deleted the chore/better-logging-dictionary-tests branch September 6, 2024 20:46
krispraws
krispraws reviewed Sep 6, 2024
View reviewed changes
Copy link

@krispraws krispraws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote up these comments yesterday but forgot to submit them :(

tests/Integration/Momento.Sdk.Tests/Cache/DictionaryTest.cs Show resolved Hide resolved
tests/Integration/Momento.Sdk.Tests/Cache/DictionaryTest.cs Show resolved Hide resolved
tests/Integration/Momento.Sdk.Tests/Cache/DictionaryTest.cs Show resolved Hide resolved
@rishtigupta
Copy link
Contributor Author

Follow-up pr - #570

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krispraws krispraws krispraws left review comments

@cprice404 cprice404 cprice404 approved these changes

@malandis malandis Awaiting requested review from malandis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rishtigupta @cprice404 @krispraws