chore: remove socket option modifier from configuration #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we had added a copy factory to `Configuration` to change `SocketHttpHandlerOptions`. While tihs was for the convenience of the `Configurations` code, this exposes a low level option to the top level of `Configuration`, which is undesirable. We remove that in this PR. The previous code using it was wholly encapsulated in `Configurations`, so not a breaking change.
nand4011
approved these changes
Feb 28, 2024
malandis
deleted the
chore/remove-sockets-options-from-config-top-level
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had added a copy factory to
Configurationto changeSocketHttpHandlerOptions. While tihs was for the convenience of theConfigurationscode, this exposed a low level detail to the toplevel of
Configuration, which is undesirable.We remove that in this PR. Since the previous code using it was wholly
encapsulated in
Configurations, this does not break other code.