feat: async factory function for eager connections #535
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the following changes:
of the CacheClient, because this can have surprising side effects,
e.g. if we want to throw an error on failure.
support eager connections at construction time.
new mechanism for create a client with an eager connection. This
matches the pattern we established in the other SDKs that support
eager connections.
rather than just logging a warning. This gives the consumer
the ability to decide how to handle this type of error rather than
us just swallowing it and removing their choice. In most cases,
users would just end up hitting a timeout error on their next
request after we gave up on the eager connection.
In the future we may add more configuration options for how to
handle eager connection failures, possibly including some
automatic retries. For now, this gives the user more control, which
seems extremely desirable given the number of times we have recently
seen users run into DNS throttling when they try to make a very
high volume of connections to Momento from lambdas.