Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add topics #468
feat: add topics #468
Changes from 1 commit
e10ae02
4f4cb06
5e1f623
f4623d1
b728deb
117257e
fc66489
be310b9
541b0e2
68b1cf3
34180b8
8382d43
9ad31e5
264d46f
d7f8738
eedc1ad
f710074
8252472
020c364
a8044e5
f0e603c
b56bfb4
9182598
0180c5b
9e49d9f
0b81e15
052d9cd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 14 in src/Momento.Sdk/Internal/ScsTopicClient.cs
GitHub Actions / build_csharp (ubuntu-latest, net6.0)
Check warning on line 14 in src/Momento.Sdk/Internal/ScsTopicClient.cs
GitHub Actions / build_csharp (windows-latest, net461)
Check warning on line 16 in src/Momento.Sdk/Internal/ScsTopicClient.cs
GitHub Actions / build_csharp (ubuntu-latest, net6.0)
Check warning on line 16 in src/Momento.Sdk/Internal/ScsTopicClient.cs
GitHub Actions / build_csharp (windows-latest, net461)
Check warning on line 20 in src/Momento.Sdk/Internal/ScsTopicClient.cs
GitHub Actions / build_csharp (ubuntu-latest, net6.0)
Check warning on line 20 in src/Momento.Sdk/Internal/ScsTopicClient.cs
GitHub Actions / build_csharp (windows-latest, net461)
Check warning on line 22 in src/Momento.Sdk/Internal/ScsTopicClient.cs
GitHub Actions / build_csharp (ubuntu-latest, net6.0)
Check warning on line 22 in src/Momento.Sdk/Internal/ScsTopicClient.cs
GitHub Actions / build_csharp (windows-latest, net461)
Check warning on line 30 in src/Momento.Sdk/Internal/ScsTopicClient.cs
GitHub Actions / build_csharp (ubuntu-latest, net6.0)
Check warning on line 30 in src/Momento.Sdk/Internal/ScsTopicClient.cs
GitHub Actions / build_csharp (windows-latest, net461)
Check warning on line 35 in src/Momento.Sdk/Internal/ScsTopicClient.cs
GitHub Actions / build_csharp (ubuntu-latest, net6.0)
Check warning on line 35 in src/Momento.Sdk/Internal/ScsTopicClient.cs
GitHub Actions / build_csharp (windows-latest, net461)
Check warning on line 40 in src/Momento.Sdk/Internal/ScsTopicClient.cs
GitHub Actions / build_csharp (ubuntu-latest, net6.0)
Check warning on line 40 in src/Momento.Sdk/Internal/ScsTopicClient.cs
GitHub Actions / build_csharp (windows-latest, net461)
Check warning on line 106 in src/Momento.Sdk/Internal/ScsTopicClient.cs
GitHub Actions / build_csharp (ubuntu-latest, net6.0)
Check warning on line 106 in src/Momento.Sdk/Internal/ScsTopicClient.cs
GitHub Actions / build_csharp (windows-latest, net461)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should probably be returning a subscription item so users can be aware of missing messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to add Discontinuity as a separate item in a second pass, but I can add it now if if won't add too much complexity to the pr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes we need to get this out the door, we will add those later