Skip to content

Commit

Permalink
chore: re-enable setSample tests
Browse files Browse the repository at this point in the history
These tests had previously been disabled because they would
cause canary failures in cells where the server changes hadn't
yet been deployed. This commit re-enables them.
  • Loading branch information
cprice404 committed Mar 7, 2024
1 parent 93f6b1d commit 88598e5
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tests/Integration/Momento.Sdk.Tests/SetTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,7 @@ public async Task SetFetchAsync_UsesCachedStringSet_HappyPath()
Assert.Same(set1, set2);
}

[Theory(Skip = "SetSample is a new API, we can't enable these tests until the server changes are deployed")]
[Theory]
[InlineData(null, "my-set", 100)]
[InlineData("cache", null, 100)]
[InlineData("cache", "my-set", -1)]
Expand All @@ -589,15 +589,15 @@ public async Task SetSampleAsync_NullChecks_IsError(string cacheName, string set
Assert.Equal(MomentoErrorCode.INVALID_ARGUMENT_ERROR, ((CacheSetSampleResponse.Error)response).ErrorCode);
}

[Fact(Skip = "SetSample is a new API, we can't enable these tests until the server changes are deployed")]
[Fact]
public async Task SetSampleAsync_Missing_HappyPath()
{
var setName = Utils.NewGuidString();
CacheSetSampleResponse response = await client.SetSampleAsync(cacheName, setName, 100);
Assert.True(response is CacheSetSampleResponse.Miss, $"Unexpected response: {response}");
}

[Fact(Skip = "SetSample is a new API, we can't enable these tests until the server changes are deployed")]
[Fact]
public async Task SetSampleAsync_UsesCachedStringSet_HappyPath()
{
var setName = Utils.NewGuidString();
Expand Down

0 comments on commit 88598e5

Please sign in to comment.