Feature/detect broken contacts #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litleleprikon
suggested changes
Mar 1, 2021
androndo
force-pushed
the
feature/detect_broken_contacts
branch
from
12a55b9 to
7deee8b
Compare
litleleprikon
suggested changes
Mar 3, 2021
senders/telegram/send.go
Outdated
| @@ -37,9 +37,15 @@ func (sender *Sender) SendEvents(events moira.NotificationEvents, contact moira. | |||
| sender.logger.Debugf("Calling telegram api with chat_id %s and message body %s", contact.Value, message) | |||
| chat, err := sender.getChat(contact.Value) | |||
| if err != nil { | |||
| if ok, errorBrokenContact := checkBrokenContactError(sender.logger, err); ok { | |||
There was a problem hiding this comment.
It's pretty strange to see that we raise an error if ok is true. Probably we need to invert bool value in return of function and invert condition here?
There was a problem hiding this comment.
Additionally: do we really need this bool value? probably we can just return SenderBrokenContactError if contact is broken and nil otherwise. And this condition will become just
if errorBrokenContact := checkBrokenContactError(sender.logger, err); errorBrokenContact != nil {There was a problem hiding this comment.
Or even better solution. Let's the function checkBrokenContactError will return SenderBrokenContactError if contact is broken or original error otherwise. And here we can remove this second if and use just
if err != nil {
return checkBrokenContactError(sender.logger, err)
}
added 10 commits
March 5, 2021 12:20
androndo
force-pushed
the
feature/detect_broken_contacts
branch
from
2176ebd to
3396a9b
Compare
litleleprikon
approved these changes
Mar 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Additional information
Relates #614