review fixes

errors.go

@@ -6,6 +6,12 @@ type SenderBrokenContactError struct {
 	SenderError error
 }
 
-func (e *SenderBrokenContactError) Error() string {
+func NewSenderBrokenContactError(senderError error) SenderBrokenContactError {
+	return SenderBrokenContactError{
+		SenderError: senderError,
+	}
+}
+
+func (e SenderBrokenContactError) Error() string {
 	return e.SenderError.Error()
 }

senders/slack/slack.go

@@ -193,7 +193,7 @@ func (sender *Sender) sendMessage(message string, contact string, triggerID stri
 		errorText := err.Error()
 		if errorText == ErrorTextChannelArchived || errorText == ErrorTextNotInChannel ||
 			errorText == ErrorTextChannelNotFound {
-			return channelID, threadTimestamp, &moira.SenderBrokenContactError{SenderError: err}
+			return channelID, threadTimestamp, moira.NewSenderBrokenContactError(err)
 		}
 		return channelID, threadTimestamp, fmt.Errorf("failed to send %s event message to slack [%s]: %s",
 			triggerID, contact, errorText)

senders/telegram/send.go

@@ -128,7 +128,7 @@ func (sender *Sender) sendAsMessage(chat *telebot.Chat, message string) error {
 			if e.Code == 401 || e.Code == 400 && (e.Message == telebot.ErrBlockedByUser.Message ||
 				e.Message == telebot.ErrEmptyChatID.Message ||
 				e.Message == telebot.ErrChatNotFound.Message) {
-				return &moira.SenderBrokenContactError{SenderError: e}
+				return moira.NewSenderBrokenContactError(err)
 			}
 		}
 		return fmt.Errorf("can't send event message [%s] to %v: %s", message, chat.ID, err.Error())