Editor grids permissions refactor, enhancements, and fixes #16653
+11,509
−8,826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smg6511
changed the title
|
@smg6511 Is this close to being ready? |
|
@opengeek Yes, very close - been hammering away at it. It should be ready for review by early next week. |
Formatting, style, optimization only
Changes to js, css, and Lexicon common to multiple areas of this PR
Changes to both grid list and Context editing page (general info)
Implements new permissions handling and fixes a couple other issues in the Dashboard editing panel: - Added validation to prevent dup Dashboard names - Styled toggles to match rest of current UI
Formatting, code style changes only
Hides actions icon for first (currently installed) package
Hides actions icon for unchanged Lexicons
Formatting, style updates only
Updates display of and ability to select row actions (gear icon, bulk actions button); includes update to getViewConfig method in base grid class
Formatting, code style changes only
Formatting, code style changes only
Final functional and minor display changes
Formatting, code style changes only
Updates display of and ability to select row actions (gear icon, bulk actions button). Also fixes index controller so users with view permissions can see the grid of Users. Lastly removes unused method for Users grid class.
Formatting, code styling changes only
Formatting, code style changes only
The new getExtrasNamespaces method was needed in places other than the main Namespaces page (via GetList); made static as well. Also updates GetList to use translatable Creator names.
Consolidate shared methods and config elements into new GridBase class
Formatting, code style & optimization changes only
Formatting, code style & optimization changes only
Updates display of and ability to select row actions (gear icon), as well as display of various action buttons. Also adjustments made to base grid class.
Interim base class fixes, updates, additions
Formatting, code style changes only. Also moved menu config from php processor to js class method for consistency.
Formatting, code style changes only
A few new fixes and additions
Apply new permissions methods
Additional cleanup, fine-tuning to application of perms, button creation optimization
Apply new permissions methods
Tweaks, clean up, and application of new create button method to various grids
smg6511
force-pushed
the
3.x-grids-permissions-rework
branch
from
3045679 to
7739175
Compare
Code style changes only
Apply new permissions methods
Formatting, code style changes only
Apply new permissions methods; includes adjustments to base grid class
Formatting, code style changes only
Render links and checkboxes according to user permissions
Remove legacy cls references and mark others for removal
Tweaks and optimizations; fix issue with fields and tvs grids not showing inactive rows properly
|
@smg6511 this is a big one—kudos on getting it to this stage! Since it's fresh on your mind and touches so many areas, it will take a while to fully review I suspect (was just discussing this with @jaygilmore and @opengeek). Any suggestions or checklists of all the various nooks and crannies that should be tested to get this one merged? |
Yeah, I'll put a little something up here later tonight... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR
See also #15919. This is a re-packaging of that PR; this new PR seeks to cover all editor grids across the application and separates out some work (for a future PR) that had been begun around internationalizing core names and descriptions within some of the grids.
Related Issues
#14929, #16507