Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Customization in MODX 3: Template names don't initially appear, or are wrong #16300

Open
SnowCreative opened this issue Nov 16, 2022 · 5 comments
Labels
bug The issue in the code or project, which should be addressed.
Milestone

Comments

@SnowCreative
Copy link
Contributor

SnowCreative commented Nov 16, 2022

Bug report

Summary

Template names in the list of manager customizations is sometimes missing, or displays the wrong template names.

Step to reproduce

Go to Form Customization, then click on customization name to edit the group.

Observed behavior

The template name column is empty.
Screen Shot 2022-11-16 at 4 50 12 PM

Reload the screen, and the names appear. Sometimes I have to reload twice.
Screen Shot 2022-11-16 at 4 50 21 PM

This happens only the first time. If you close out of the customization group, then go back to it, the template names are still there. If, however, you clear the browser cache, then go back to the customization group, the template names are gone again. I've tried with 3 different browsers.

HOWEVER, sometimes the template names that do show up are wrong, so the same template name may appear multiple times, even though there is only one customization set for that template.

Expected behavior

Template names should appear on first viewing.

Environment

MODX 3 (all versions)

@SnowCreative SnowCreative added the bug The issue in the code or project, which should be addressed. label Nov 16, 2022
@smg6511
Copy link
Collaborator

smg6511 commented Nov 16, 2022

I looked at one live site running 3.0.1 and my 3.0.2-dev local install and did not see this issue.

UPDATE: Now I'm seeing this issue in various scenarios on 3.0.3-dev—sometimes when first opening a profile, sometimes after editing and closing a profile rule. Will have to look into it.

Additionally, incorrect template names are showing up on some rules (although the saved value is correct); a similar issue can happen with the media source grid component (shown in the TV creation page), particularly when the component is paged and an option is chosen from the 2nd+ page).

@deJaya
Copy link

deJaya commented Jul 18, 2023

Additionally, incorrect template names are showing up on some rules (although the saved value is correct);

I am seeing this too. It seems to be worse when there are a lot of rules. Red highlighted rules show incorrect [or missing] templates:

image

Opening each rule shows everything as it should be - but it's hard to know which rule is which.

MODX 3.0.3-pl PHP 8.2

@SnowCreative
Copy link
Contributor Author

Can we get this on a milestone somewhere?

@SnowCreative SnowCreative changed the title Form Customization in MODX 3: Template names don't initially appear Form Customization in MODX 3: Template names don't initially appear, or are wrong Apr 10, 2024
@opengeek opengeek added this to the v3.0.6 milestone Apr 10, 2024
@smg6511
Copy link
Collaborator

smg6511 commented Apr 12, 2024

I'll take a look again at this soon. I played with this at one point (when verifying the issue earlier) and found it to be particularly tricky to solve. This is an issue for any multi-page combo (having more than 10 items) used in an editor grid.

@opengeek opengeek modified the milestones: v3.0.6, v3.1.0 Dec 9, 2024
@smg6511
Copy link
Collaborator

smg6511 commented Dec 11, 2024

Update: My recent PR (#16653) happens to solve this issue for the FC grid by removing the combo editor and simply rendering the template name with a link to its respective FC Set. The combo editor problem was proving to be too difficult to fix now and for the foreseeable future, so this change at least side-steps the bad UX of missing and incorrect template names showing up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue in the code or project, which should be addressed.
Projects
None yet
Development

No branches or pull requests

4 participants