Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stdlib] Rename bit_ceil and bit_floor #3895

Closed

Conversation

martinvuyk
Copy link
Contributor

Rename bit_ceil and bit_floor. Closes #3271

@martinvuyk martinvuyk requested a review from a team as a code owner December 18, 2024 12:35
Copy link
Collaborator

@JoeLoser JoeLoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JoeLoser
Copy link
Collaborator

!sync

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Dec 18, 2024
@modularbot
Copy link
Collaborator

✅🟣 This contribution has been merged 🟣✅

Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours.

We use Copybara to merge external contributions, click here to learn more.

@modularbot modularbot added the merged-internally Indicates that this pull request has been merged internally label Dec 18, 2024
@modularbot
Copy link
Collaborator

Landed in 98498ed! Thank you for your contribution 🎉

@modularbot modularbot added the merged-externally Merged externally in public mojo repo label Dec 21, 2024
modularbot pushed a commit that referenced this pull request Dec 21, 2024
[External] [stdlib] Rename `bit_ceil` and `bit_floor`

Rename `bit_ceil` and `bit_floor`. Closes #3271

Co-authored-by: martinvuyk <[email protected]>
Closes #3895
MODULAR_ORIG_COMMIT_REV_ID: 416856b02b0851cc5725b13fcb6febeee74b957c
@modularbot modularbot closed this Dec 21, 2024
msaelices pushed a commit to msaelices/mojo that referenced this pull request Dec 22, 2024
[External] [stdlib] Rename `bit_ceil` and `bit_floor`

Rename `bit_ceil` and `bit_floor`. Closes modularml#3271

Co-authored-by: martinvuyk <[email protected]>
Closes modularml#3895
MODULAR_ORIG_COMMIT_REV_ID: 416856b02b0851cc5725b13fcb6febeee74b957c
@martinvuyk martinvuyk deleted the rename-bitceil-and-bitfloor branch December 22, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported-internally Signals that a given pull request has been imported internally. merged-externally Merged externally in public mojo repo merged-internally Indicates that this pull request has been merged internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants