Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stdlib] Add _write_hex util #3873

Open
wants to merge 16 commits into
base: nightly
Choose a base branch
from
Open

[stdlib] Add _write_hex util #3873

wants to merge 16 commits into from

Conversation

martinvuyk
Copy link
Contributor

Add _write_hex util.

This is a split-off from #3686. It is needed for that and any implementation that needs to write a hexadecimal value to a pointer as fast as possible.

@martinvuyk
add _write_hex util
dedce22 
Signed-off-by: martinvuyk <[email protected]>
@martinvuyk martinvuyk requested a review from a team as a code owner December 12, 2024 13:22
@soraros
Copy link
Contributor

soraros commented Dec 19, 2024

I have a SIMD-rich _write_hex in #3694, maybe we can just use that?

@martinvuyk
add the implementation from modularml#3694 by @soraros
ac5c11b 
Signed-off-by: martinvuyk <[email protected]>
@martinvuyk
add examples and unit test
4cbdf9b 
Signed-off-by: martinvuyk <[email protected]>
@martinvuyk
fix examples
8f501c7 
Signed-off-by: martinvuyk <[email protected]>
@martinvuyk
fix examples
0df9c64 
Signed-off-by: martinvuyk <[email protected]>
@martinvuyk
fix examples
493c6f9 
Signed-off-by: martinvuyk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ConnorGray ConnorGray

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinvuyk @soraros @ConnorGray