Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stdlib] Remove StringLiteral StringRef dependencies #3869

Open
wants to merge 10 commits into
base: nightly
Choose a base branch
from

Conversation

martinvuyk
Copy link
Contributor

Remove StringLiteral StringRef dependencies

@martinvuyk martinvuyk requested a review from a team as a code owner December 11, 2024 19:35
@martinvuyk martinvuyk force-pushed the remove-stringliteral-stringref-dependencies branch from ef123d5 to b58e646 Compare December 11, 2024 19:59
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
Copy link
Collaborator

@JoeLoser JoeLoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please address my small comment before I sync.

stdlib/src/utils/string_slice.mojo Outdated Show resolved Hide resolved
@JoeLoser JoeLoser self-assigned this Dec 13, 2024
@ConnorGray
Copy link
Collaborator

!sync

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported-internally Signals that a given pull request has been imported internally.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants