Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stdlib] Remove StringRef.split() #3865

Open
wants to merge 3 commits into
base: nightly
Choose a base branch
from

Conversation

martinvuyk
Copy link
Contributor

Remove StringRef.split().

This method does not behave like Python's, and we already have this in StringSlice.

Add a changelog entry explicitly stating that StringRef is to be deprecated.

Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
@martinvuyk martinvuyk requested a review from a team as a code owner December 11, 2024 18:32
Copy link
Collaborator

@JoeLoser JoeLoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, any concerns @ConnorGray?

@JoeLoser
Copy link
Collaborator

!sync

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Dec 13, 2024
@JoeLoser
Copy link
Collaborator

!sync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported-internally Signals that a given pull request has been imported internally.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants