[stdlib] Addition of a new constructor and reserve method to the String struct #3755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@martinvuyk I made your suggested change to the docstring of the reserve function! |
thatstoasty
force-pushed
the
str-reserve
branch
from
f0d2c80 to
3d89763
Compare
Signed-off-by: Mikhail Tavarez <[email protected]> revise changelog Signed-off-by: Mikhail Tavarez <[email protected]>
thatstoasty
force-pushed
the
str-reserve
branch
from
3d89763 to
7eb5588
Compare
JoeLoser
approved these changes
Nov 8, 2024
|
!sync |
modularbot
added
the
imported-internally
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
merged-internally
modularbot
pushed a commit
that referenced
this pull request
Nov 9, 2024
…to the String struct (#50557) [External] [stdlib] Addition of a new constructor and reserve method to the String struct Adds a public API for users to allocate capacity through String, instead of having to reach into the private internal `._buffer` attribute. Satisfies: #3738 Co-authored-by: Mikhail Tavarez <[email protected]> Closes #3755 MODULAR_ORIG_COMMIT_REV_ID: 3d3c3c4fd49acaf3f8f204e453039bacfe57a8ac
|
Landed in 55cbae5! Thank you for your contribution 🎉 |
modularbot
pushed a commit
that referenced
this pull request
Dec 17, 2024
…to the String struct (#50557) [External] [stdlib] Addition of a new constructor and reserve method to the String struct Adds a public API for users to allocate capacity through String, instead of having to reach into the private internal `._buffer` attribute. Satisfies: #3738 Co-authored-by: Mikhail Tavarez <[email protected]> Closes #3755 MODULAR_ORIG_COMMIT_REV_ID: 3d3c3c4fd49acaf3f8f204e453039bacfe57a8ac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a public API for users to allocate capacity through String, instead of having to reach into the private internal
._bufferattribute.Satisfies: #3738