[stdlib] Make Slice step Optional
#3160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgreni
changed the title
Slice step OptionalRegSlice step OptionalReg
JoeLoser
reviewed
Jul 2, 2024
There was a problem hiding this comment.
@ConnorGray or @rparolin - do you mind checking the perf impact of this, please?
bgreni
force-pushed
the
slice-step-optional
branch
2 times, most recently
from
3250ae9 to
0d9348d
Compare
|
Let's hold off on this for a bit since @lattner has a PR up internally to change |
|
|
bgreni
force-pushed
the
slice-step-optional
branch
from
0d9348d to
6ee674f
Compare
bgreni
changed the title
Slice step OptionalRegSlice step Optional
gryznar
reviewed
Jul 11, 2024
bgreni
force-pushed
the
slice-step-optional
branch
2 times, most recently
from
cb01789 to
1c574ae
Compare
bgreni
force-pushed
the
slice-step-optional
branch
2 times, most recently
from
f55b116 to
63b294f
Compare
bgreni
force-pushed
the
slice-step-optional
branch
3 times, most recently
from
6fd634b to
f9fcaeb
Compare
bgreni
force-pushed
the
slice-step-optional
branch
2 times, most recently
from
7d24a10 to
651e5fe
Compare
bgreni
force-pushed
the
slice-step-optional
branch
2 times, most recently
from
208dbbd to
9399dc4
Compare
bgreni
force-pushed
the
slice-step-optional
branch
from
9399dc4 to
e5887da
Compare
|
Hey @bgreni, what's the benefit of making |
Signed-off-by: Brian Grenier <[email protected]>
bgreni
force-pushed
the
slice-step-optional
branch
from
e5887da to
bd5047a
Compare
|
!sync |
modularbot
added
the
imported-internally
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
merged-internally
|
Landed in 630f621! Thank you for your contribution 🎉 |
modularbot
pushed a commit
that referenced
this pull request
Oct 16, 2024
Follow up from #3064 (comment) Make `step` member of `Slice` `Optional` in order to better match the behaviour/semantics of the Python slice. Co-authored-by: bgreni <[email protected]> Closes #3160 MODULAR_ORIG_COMMIT_REV_ID: dcfe50395856e038b64deb6d88e8d68a69edeae4
modularbot
pushed a commit
that referenced
this pull request
Dec 17, 2024
Follow up from #3064 (comment) Make `step` member of `Slice` `Optional` in order to better match the behaviour/semantics of the Python slice. Co-authored-by: bgreni <[email protected]> Closes #3160 MODULAR_ORIG_COMMIT_REV_ID: dcfe50395856e038b64deb6d88e8d68a69edeae4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #3064 (comment)
Make
stepmember ofSliceOptionalin order to better match the behaviour/semantics of the Python slice.