Fix fabric ordering + add neoforge support #127
GitHub Actions / clippy
succeeded
Nov 8, 2023 in 0s
clippy
3 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 0 |
| Warning | 3 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.73.0 (cc66ad468 2023-10-03)
- cargo 1.73.0 (9c4383fb5 2023-08-26)
- clippy 0.1.73 (cc66ad4 2023-10-03)
Annotations
Check warning on line 75 in daedalus_client/src/neo.rs
github-actions / clippy
this creates an owned instance just for comparison
warning: this creates an owned instance just for comparison
--> daedalus_client/src/neo.rs:75:176
|
75 | ...ler.jar", loader_version_full, if new_forge == "true".to_string() { "neoforge" } else { "forge" }), None, semaphore.clone()).await?;
| ^^^^^^^^^^^^^^^^^^ help: try: `*"true"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
= note: `#[warn(clippy::cmp_owned)]` on by default
Check warning on line 9 in daedalus_client/src/neo.rs
github-actions / clippy
unused import: `HashSet`
warning: unused import: `HashSet`
--> daedalus_client/src/neo.rs:9:33
|
9 | use std::collections::{HashMap, HashSet};
| ^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
Check warning on line 45 in daedalus/src/modded.rs
github-actions / clippy
use of deprecated method `chrono::TimeZone::datetime_from_str`: use `DateTime::parse_from_str` instead
warning: use of deprecated method `chrono::TimeZone::datetime_from_str`: use `DateTime::parse_from_str` instead
--> daedalus/src/modded.rs:45:26
|
45 | .or_else(|_| Utc.datetime_from_str(&s, "%Y-%m-%dT%H:%M:%S%.f"))
| ^^^^^^^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
Loading