[wip] rewrite daedalus, vanilla, fabric, and quilt #138
GeometricallyAnnotations
1 error and 28 warnings
|
docker
buildx failed with: ERROR: failed to solve: process "/bin/sh -c cargo build --release" did not complete successfully: exit code: 101
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
daedalus_client/src/main.rs#L127
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> daedalus_client/src/main.rs:127:39
|
127 | .entry(get_path_from_artifact(&artifact)?)
| ^^^^^^^^^ help: change this to: `artifact`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
daedalus_client/src/util.rs#L250
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> daedalus_client/src/util.rs:250:25
|
250 | &path,
| ^^^^^ help: change this to: `path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
daedalus_client/src/util.rs#L234
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> daedalus_client/src/util.rs:234:29
|
234 | ... &path,
| ^^^^^ help: change this to: `path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
daedalus_client/src/util.rs#L221
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> daedalus_client/src/util.rs:221:29
|
221 | ... &path,
| ^^^^^ help: change this to: `path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
daedalus_client/src/util.rs#L173
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> daedalus_client/src/util.rs:173:48
|
173 | .initiate_multipart_upload(&path, &content_type)
| ^^^^^ help: change this to: `path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
called `map(..).flatten()` on `Option`:
daedalus_client/src/util.rs#L148
warning: called `map(..).flatten()` on `Option`
--> daedalus_client/src/util.rs:148:18
|
148 | .map(|ct| ct.to_str().ok())
| __________________^
149 | | .flatten()
| |__________________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|ct| ct.to_str().ok())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten
= note: `#[warn(clippy::map_flatten)]` on by default
|
|
returning the result of a `let` binding from a block:
daedalus_client/src/util.rs#L59
warning: returning the result of a `let` binding from a block
--> daedalus_client/src/util.rs:59:9
|
52 | / let client = reqwest::Client::builder()
53 | | .tcp_keepalive(Some(std::time::Duration::from_secs(10)))
54 | | .timeout(std::time::Duration::from_secs(15))
55 | | .default_headers(headers)
56 | | .build()
57 | | .unwrap();
| |______________________- unnecessary `let` binding
58 |
59 | client
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
52 ~
53 |
54 ~ reqwest::Client::builder()
55 + .tcp_keepalive(Some(std::time::Duration::from_secs(10)))
56 + .timeout(std::time::Duration::from_secs(15))
57 + .default_headers(headers)
58 + .build()
59 + .unwrap()
|
|
|
redundant closure:
daedalus_client/src/minecraft.rs#L104
warning: redundant closure
--> daedalus_client/src/minecraft.rs:104:48
|
104 | .map(|x| serde_json::to_vec(x).map(|x| bytes::Bytes::from(x)))
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `bytes::Bytes::from`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
|
|
redundant closure:
daedalus_client/src/fabric.rs#L169
warning: redundant closure
--> daedalus_client/src/fabric.rs:169:48
|
169 | .map(|x| serde_json::to_vec(x).map(|x| bytes::Bytes::from(x)))
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `bytes::Bytes::from`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
daedalus_client/src/fabric.rs#L148
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> daedalus_client/src/fabric.rs:148:29
|
148 | ... &mirror_artifacts,
| ^^^^^^^^^^^^^^^^^ help: change this to: `mirror_artifacts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
daedalus_client/src/fabric.rs#L109
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> daedalus_client/src/fabric.rs:109:17
|
109 | &mirror_artifacts,
| ^^^^^^^^^^^^^^^^^ help: change this to: `mirror_artifacts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
fields `separator`, `build`, and `maven` are never read:
daedalus_client/src/fabric.rs#L259
warning: fields `separator`, `build`, and `maven` are never read
--> daedalus_client/src/fabric.rs:259:9
|
258 | struct FabricLoaderVersion {
| ------------------- fields in this struct
259 | pub separator: String,
| ^^^^^^^^^
260 | pub build: u32,
| ^^^^^
261 | pub maven: String,
| ^^^^^
|
= note: `FabricLoaderVersion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
|
|
type `minecraft::LibraryPatch` is more private than the item `minecraft::patch_library`:
daedalus_client/src/minecraft.rs#L194
warning: type `minecraft::LibraryPatch` is more private than the item `minecraft::patch_library`
--> daedalus_client/src/minecraft.rs:194:1
|
194 | / pub fn patch_library(
195 | | patches: &Vec<LibraryPatch>,
196 | | mut library: Library,
197 | | ) -> Vec<Library> {
| |_________________^ function `minecraft::patch_library` is reachable at visibility `pub(crate)`
|
note: but type `minecraft::LibraryPatch` is only usable at visibility `pub(self)`
--> daedalus_client/src/minecraft.rs:178:1
|
178 | struct LibraryPatch {
| ^^^^^^^^^^^^^^^^^^^
= note: `#[warn(private_interfaces)]` on by default
|
|
unused import: `std::time::Duration`:
daedalus_client/src/main.rs#L7
warning: unused import: `std::time::Duration`
--> daedalus_client/src/main.rs:7:5
|
7 | use std::time::Duration;
| ^^^^^^^^^^^^^^^^^^^
|
|
unused import: `upload_url_to_bucket`:
daedalus_client/src/main.rs#L2
warning: unused import: `upload_url_to_bucket`
--> daedalus_client/src/main.rs:2:28
|
2 | upload_file_to_bucket, upload_url_to_bucket, upload_url_to_bucket_mirrors,
| ^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
use of deprecated method `chrono::TimeZone::datetime_from_str`: use `DateTime::parse_from_str` or `NaiveDateTime::parse_from_str` with `and_utc()` or `and_local_timezone()` instead:
daedalus/src/modded.rs#L36
warning: use of deprecated method `chrono::TimeZone::datetime_from_str`: use `DateTime::parse_from_str` or `NaiveDateTime::parse_from_str` with `and_utc()` or `and_local_timezone()` instead
--> daedalus/src/modded.rs:36:26
|
36 | .or_else(|_| Utc.datetime_from_str(&s, "%Y-%m-%dT%H:%M:%S%.9f"))
| ^^^^^^^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
docker
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, docker/metadata-action@v3, docker/login-action@v1, docker/build-push-action@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
docker
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, docker/metadata-action@v3, docker/login-action@v1, docker/build-push-action@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
docker
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
docker
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
docker
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
docker
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
docker
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
docker
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
docker
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
docker
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
docker
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
docker
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|