fix: Disable Run Meta on forks (#19)
#102
GeometricallyAnnotations
14 warnings
|
the borrowed expression implements the required traits:
daedalus_client/src/util.rs#L162
warning: the borrowed expression implements the required traits
--> daedalus_client/src/util.rs:162:18
|
162 | .get(&url.replace("http://", "https://"))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `url.replace("http://", "https://")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
this function has too many arguments (8/7):
daedalus_client/src/fabric.rs#L50
warning: this function has too many arguments (8/7)
--> daedalus_client/src/fabric.rs:50:1
|
50 | #[tracing::instrument(skip(semaphore, upload_files, mirror_artifacts))]
| ^----------------------------------------------------------------------
| |
| _in this procedural macro expansion
| |
51 | | async fn fetch(
52 | | format_version: usize,
53 | | mod_loader: &str,
... |
59 | | mirror_artifacts: &DashMap<String, MirrorArtifact>,
60 | | ) -> Result<(), Error> {
| |______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
= note: this warning originates in the attribute macro `tracing::instrument` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
field `path` is never read:
daedalus_client/src/forge.rs#L445
warning: field `path` is never read
--> daedalus_client/src/forge.rs:445:25
|
440 | struct ForgeInstallerProfileV2 {
| ----------------------- field in this struct
...
445 | pub path: Option<String>,
| ^^^^
|
= note: `ForgeInstallerProfileV2` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
|
|
variable does not need to be mutable:
daedalus_client/src/main.rs#L163
warning: variable does not need to be mutable
--> daedalus_client/src/main.rs:163:9
|
163 | let mut val = mirror_artifacts
| ----^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
|
unused import: `sha1_async`:
daedalus_client/src/forge.rs#L2
warning: unused import: `sha1_async`
--> daedalus_client/src/forge.rs:2:55
|
2 | download_file, fetch_json, fetch_xml, format_url, sha1_async,
| ^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
use of deprecated method `chrono::TimeZone::datetime_from_str`: use `DateTime::parse_from_str` or `NaiveDateTime::parse_from_str` with `and_utc()` or `and_local_timezone()` instead:
daedalus/src/modded.rs#L36
warning: use of deprecated method `chrono::TimeZone::datetime_from_str`: use `DateTime::parse_from_str` or `NaiveDateTime::parse_from_str` with `and_utc()` or `and_local_timezone()` instead
--> daedalus/src/modded.rs:36:26
|
36 | .or_else(|_| Utc.datetime_from_str(&s, "%Y-%m-%dT%H:%M:%S%.9f"))
| ^^^^^^^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
|
unexpected `cfg` condition value: `bincode`:
daedalus/src/minecraft.rs#L436
warning: unexpected `cfg` condition value: `bincode`
--> daedalus/src/minecraft.rs:436:16
|
436 | #[cfg_attr(feature = "bincode", bincode(with_serde))]
| ^^^^^^^^^^^^^^^^^^^ help: remove the condition
|
= note: no expected values for `feature`
= help: consider adding `bincode` as a feature in `Cargo.toml`
= note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
|
|
unexpected `cfg` condition value: `bincode`:
daedalus/src/minecraft.rs#L433
warning: unexpected `cfg` condition value: `bincode`
--> daedalus/src/minecraft.rs:433:16
|
433 | #[cfg_attr(feature = "bincode", bincode(with_serde))]
| ^^^^^^^^^^^^^^^^^^^ help: remove the condition
|
= note: no expected values for `feature`
= help: consider adding `bincode` as a feature in `Cargo.toml`
= note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
= note: `#[warn(unexpected_cfgs)]` on by default
|
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
build
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v2, actions/cache@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|