Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update highlight-weakness.js #53

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/reviewdog.yml
Original file line number Diff line number Diff line change
@@ -1,20 +1,22 @@
name: reviewdog

# read-only repo token
# no access to secrets
on:
pull_request:
paths-ignore:
- '!.github/**'

jobs:
eslint:
name: runner / eslint
runs-on: ubuntu-latest

permissions:
contents: read
pull-requests: write

steps:
- uses: actions/checkout@v2
- uses: reviewdog/action-eslint@v1
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
reporter: github-pr-review
level: error
fail_on_error: true
4 changes: 2 additions & 2 deletions plugins/highlight-weakness.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ var changelog = [
{
version: '0.8.1',
changes: ['Version upgrade due to a change in the wrapper: added plugin icon'],
},
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ,

Suggested change
}
},

];

function weaknessHighlight (data) {
function weaknessHighlight ( data) {

Comment on lines +17 to 18

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·(·data)·{⏎ with (data)·{

Suggested change
function weaknessHighlight ( data) {
function weaknessHighlight(data) {

if (data.portal.options.data.resCount !== undefined
&& data.portal.options.data.health !== undefined
Expand Down
Loading