Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update basemap-openstreetmap.js #52

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/workflows/reviewdog.yml
Original file line number Diff line number Diff line change
@@ -1,20 +1,23 @@
name: reviewdog

# read-only repo token
# no access to secrets
on:
pull_request:
paths-ignore:
- '!.github/**'

jobs:
eslint:
name: runner / eslint
runs-on: ubuntu-latest

permissions:
checks: write
contents: read
pull-requests: read

steps:
- uses: actions/checkout@v2
- uses: reviewdog/action-eslint@v1
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
reporter: github-pr-review
level: error
fail_on_error: true
4 changes: 2 additions & 2 deletions plugins/basemap-openstreetmap.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ var changelog = [
{
version: '0.1.3',
changes: ['Update OSM tile provider', 'Add CyclOSM tiles', 'Expose config'],
},
}
];

// https://wiki.openstreetmap.org/wiki/Raster_tile_providers
Expand Down Expand Up @@ -53,7 +53,7 @@ function setup() {
// OpenStreetMap tiles - we shouldn't use these by default - https://wiki.openstreetmap.org/wiki/Tile_usage_policy
// "Heavy use (e.g. distributing an app that uses tiles from openstreetmap.org) is forbidden without prior permission from the System Administrators"

for (var entry of mapOpenStreetMap.LAYERS) {
for ( var entry of mapOpenStreetMap.LAYERS ) {
var layer = new L.TileLayer(entry.url, entry.options);
layerChooser.addBaseLayer(layer, entry.name);
}
Expand Down
Loading