Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update basemap-bing.js #51

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update basemap-bing.js #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06e7795
Fix reviewdog permissions
modos189 Aug 13, 2024
e28d47c
Merge pull request #49 from modos189/fix/reviewdog-permissions
modos189 Aug 13, 2024
9a05fa2
Update reviewdog.yml
modos189 Aug 13, 2024
abbf23e
Update basemap-bing.js
modos189 Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/reviewdog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
name: reviewdog

# read-only repo token
# no access to secrets
on:
pull_request:
paths-ignore:
- '!.github/**'

jobs:
eslint:
Expand Down
4 changes: 2 additions & 2 deletions plugins/basemap-bing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ var changelog = [
{
version: '0.3.2',
changes: ['Version upgrade due to a change in the wrapper: added plugin icon'],
},
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ,

Suggested change
}
},

];

// use own namespace for plugin
Expand Down Expand Up @@ -40,7 +40,7 @@ mapBing.options = {
function setup () {
setupBingLeaflet();

for (var name in mapBing.sets) {
for ( var name in mapBing.sets) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ·

Suggested change
for ( var name in mapBing.sets) {
for (var name in mapBing.sets) {

var options = L.extend({}, mapBing.options, mapBing.sets[name]);
layerChooser.addBaseLayer(L.bingLayer(options), 'Bing ' + name);
}
Expand Down
Loading