FacebookDataRetriever no longer works (it seems) - a fix! #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…count' index in the 'likes' part of the JSON response. This is a fix I made, which first tries to use the 'count' index, but does a quick calculation if it isn't present. This issue is also reported on the Kurogo community boards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the FacebookDataRetriever is broken. For me and several other users, as reported on the community boards, it errors out saying that there is an undefined index 'count' on line 136.
Looking at the FB JSON response, it seems that the 'count' index is indeed missing from the 'likes' array. This is a fix for the issue, which first tries to use the 'count' index, but does a quick calculation to calculate the likes if it isn't given by the JSON.