-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT-#5253: Upgrade pandas to 1.5.2 #5254
FEAT-#5253: Upgrade pandas to 1.5.2 #5254
Conversation
bd5f45e
to
752abc3
Compare
environment-dev.yml
Outdated
# TODO(https://github.com/modin-project/modin/issues/5256): Move pandas back | ||
# to installation with conda | ||
- pandas==1.5.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like plain wrong. This should be investigated (for example, we won't be able to make a conda-forge release doing things like that).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand what you mean by "plain wrong". We have already been installing Ray, for instance, from PyPI in environment-dev.yml. I do not see anything bad if we install pandas from PyPI for now in order not to stop making the release in PyPI. While we are preparing the release for PyPI, we can investigate the issue in backgroung and when we come to the release in conda-forge, the issue might already be resolved. Created conda-incubator/setup-miniconda#264. So I propose to merge the changes as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the fact that we mix things from pip
and conda
is causing us issues already - #5208 (probable cause explained around conda-forge/ray-packages-feedstock#78 (comment)).
Plus it means we're not testing what our typical end user is installing, I think most customers use either pip
or conda
but not a semi-random mix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that we shouldn't mix things from pip
and conda
but we have been doing that for a quite a long time (e.g., Ray). The fact we currenlty install pandas from conda
and Ray from pip
doesn't guarantee the correctness of Modin as we don't test this. Here is the similar case. My proposals are
- Merge the changes as is.
- Wait for a response in nothing provides requested pandas 1.5.2 conda-incubator/setup-miniconda#264 or BUILD: pandas 1.5.2 can't be installed with conda-incubator/setup-miniconda@v2 pandas-dev/pandas#49894.
If you have anything else, you're welcome.
I tried to use channels
option for conda-incubator/setup-miniconda@v2
in GH Actions to specify conda-forge
manually and it didn't work.
I tried to remove pandas from the file and install it manually with conda install pandas=1.5.2 -c conda-forge
in GH Actions. It didn't work too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I returned back pandas to installation with conda. See more about the fix in conda-incubator/setup-miniconda#264.
Signed-off-by: Igoshev, Iaroslav <[email protected]>
522137f
to
4e7af4a
Compare
Signed-off-by: Igoshev, Iaroslav <[email protected]>
4e7af4a
to
912de9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, awesome you've figured it our @YarShev!
* Set use-only-tar-bz2 to false Signed-off-by: Igoshev, Iaroslav <[email protected]>
Signed-off-by: Igoshev, Iaroslav [email protected]
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
docs/development/architecture.rst
is up-to-date