Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(netcdf): support creating and loading model netcdf input files #2417

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

mjreno
Copy link
Contributor

@mjreno mjreno commented Jan 13, 2025

No description provided.

@mjreno mjreno marked this pull request as draft January 13, 2025 19:13
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 90.95890% with 33 lines in your changes missing coverage. Please review.

Project coverage is 76.4%. Comparing base (bb9824e) to head (8c59095).
Report is 35 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/utils/model_netcdf.py 89.7% 27 Missing ⚠️
flopy/mf6/data/mfdataarray.py 93.5% 2 Missing ⚠️
flopy/mf6/mfmodel.py 92.3% 2 Missing ⚠️
flopy/mf6/mfpackage.py 83.3% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2417     +/-   ##
=========================================
+ Coverage     68.4%   76.4%   +7.9%     
=========================================
  Files          294     295      +1     
  Lines        59390   60180    +790     
=========================================
+ Hits         40652   45988   +5336     
+ Misses       18738   14192   -4546     
Files with missing lines Coverage Δ
flopy/mf6/data/mfdataplist.py 79.8% <100.0%> (+7.2%) ⬆️
flopy/mf6/data/mfdatastorage.py 75.8% <100.0%> (+6.9%) ⬆️
flopy/mf6/data/mffileaccess.py 75.8% <100.0%> (+4.8%) ⬆️
flopy/mf6/data/mfstructure.py 64.1% <100.0%> (+<0.1%) ⬆️
flopy/mf6/mfsimbase.py 75.5% <100.0%> (+13.3%) ⬆️
flopy/mf6/data/mfdataarray.py 68.1% <93.5%> (+9.6%) ⬆️
flopy/mf6/mfmodel.py 84.2% <92.3%> (+28.2%) ⬆️
flopy/mf6/mfpackage.py 82.0% <83.3%> (+17.3%) ⬆️
flopy/utils/model_netcdf.py 89.7% <89.7%> (ø)

... and 243 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant