Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More ModelStructure verification #31

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

More ModelStructure verification #31

wants to merge 10 commits into from

Conversation

filip-stenstrom
Copy link
Collaborator

@filip-stenstrom filip-stenstrom commented Mar 31, 2023 •
edited
Loading

Work remaining: implementation for FMI3

Adding ModelStructure verification:

1.
    a. MS.Outputs.Unknown.index must be an output  # (issues/23)
    b. MV.SV.causality="output" must exist in MS.Outputs.Unknown.index  # (issues/23)
2. MS.Outputs.Unknown.dependencies[i] must be a valid dependency  # (issues/23)
3. MS.Derivatives.Unknown.dependencies[i] must be a valid dependency  # (no explicit issue, but related to issues/23)
4. MS.InitialUnknowns.Unknown.dependencies[i] must be a valid dependency  # (no explicit issue, but related to both issues)
5. MS.InitialUnknown.index must be valid  # (issues/27, also noted in first comment in issues/23)

Intends to solve Checker github issues:

@filip-stenstrom
Add test for ModelStructure.Derivatives verification
30d8f25 
We already had code that performed the check, but no test for it.

The committed test code is in large parts copied from PR 21. When
possible (either before merging this story, or after both are merged),
remember to extract the test functions to some test utils unit.
@filip-stenstrom
Check that all output variables are in MS.Outputs
4694146 
Also started to create a more flexible way of testing the log output.
It's copied + built on the content of other branches, but I'll
merge/extract everything as the branches get merged.
@filip-stenstrom
Check that MS.Outputs indices reference outputs
e3128df
@filip-stenstrom
Check dependencies for MS.Outputs
c83a001
@filip-stenstrom
Check MD.Derivatives's dependencies
a6b729d 
Also make bad dependency indices fatal error, to avoid potential segfaults
@filip-stenstrom
Make logging of index 1-based
0d4f9a3
@filip-stenstrom
Refactor test function names
98e7470 
Function names do not follow the naming convention for types, but it's
readable, and the code is isolated to testing.
@filip-stenstrom
Remove everything related to DiscreteStates
22e27f5 
I believe this element existed in FMI 2.0 alpha/beta, but never made it
to the release.
@filip-stenstrom
Check dependency list for InitialUnknown
c4672ce 
Using 'class' pattern because it makes code less messy and makes
function encapsulation better. Downside is a lot of structural code.
@filip-stenstrom
Refactor comments
e881f14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@filip-stenstrom