Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use plain path instead of URI for resourcePath #149

Merged
merged 6 commits into from
Oct 29, 2024
Merged

Use plain path instead of URI for resourcePath #149

merged 6 commits into from
Oct 29, 2024

Conversation

filip-stenstrom
Copy link
Collaborator

FMI 2 expects a URI for the resourcePath argument given to fmi2Instantiate, but in FMI 3 it's just a plain path. I.e. not a URI, and should therefore not get file URI prefix.

PeterMeisrimelModelon
PeterMeisrimelModelon approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@PeterMeisrimelModelon PeterMeisrimelModelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, minor comment on the test.

Test/FMI3/fmi3_import_sim_me_test.cpp Show resolved Hide resolved
@filip-stenstrom filip-stenstrom merged commit aec4c76 into master Oct 29, 2024
2 checks passed
@filip-stenstrom filip-stenstrom self-assigned this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterMeisrimelModelon PeterMeisrimelModelon PeterMeisrimelModelon approved these changes

Assignees

@filip-stenstrom filip-stenstrom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filip-stenstrom @PeterMeisrimelModelon