Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed chmod of script + added file separator for resourcePath #144

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Removed chmod of script + added file separator for resourcePath #144

merged 3 commits into from
Oct 8, 2024

Conversation

modelonrobinandersson
Copy link
Member

@modelonrobinandersson modelonrobinandersson self-assigned this Oct 4, 2024
filip-stenstrom
filip-stenstrom reviewed Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@filip-stenstrom filip-stenstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Maybe write something in release notes.
  • Optional, but if you want to add a test, you can probably add an assert fmu3_model.c instantiation for the dummy FMU that resourcePath ends with /.

src/Import/src/FMI3/fmi3_import.c Show resolved Hide resolved
@modelonrobinandersson modelonrobinandersson merged commit f2f2a7b into master Oct 8, 2024
2 checks passed
@modelonrobinandersson modelonrobinandersson deleted the dev-ra-file-sep-fix branch October 8, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filip-stenstrom filip-stenstrom filip-stenstrom approved these changes

Assignees

@modelonrobinandersson modelonrobinandersson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@modelonrobinandersson @filip-stenstrom