Add commonly used Blocks and Interfaces #4518
Open
+753
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beutlich
added
enhancement
|
Thanks for the PR. Can you please resolve the few issues reported by the static checks, see https://github.com/modelica/ModelicaStandardLibrary/pull/4518/files. |
beutlich
reviewed
Jan 17, 2025
Co-authored-by: Thomas Beutlich <[email protected]>
m-kormann
force-pushed
the
add-common-blocks
branch
from
f6d617e to
b3e9b89
Compare
|
Sure! All checks should pass now and I rebased the branch on current master. |
beutlich
reviewed
Jan 20, 2025
| @@ -997,6 +997,67 @@ y = u1 * u2; | |||
| Ellipse(lineColor={0,0,127}, extent={{-50,-50},{50,50}})})); | |||
| end Product; | |||
|
|
|||
| block VectorProduct "Output product of the two inputs with dimension n" | |||
There was a problem hiding this comment.
Should it be ScalarProduct? Or DotProduct?
| annotation ( | ||
| Documentation( | ||
| info = "<html> | ||
| <p>This blocks computes the output <strong>y</strong> as <em>product</em> of the two input vectors <strong>u1</strong> and <strong>u2</strong>: </p> |
There was a problem hiding this comment.
Suggested change
| <p>This blocks computes the output <strong>y</strong> as <em>product</em> of the two input vectors <strong>u1</strong> and <strong>u2</strong>: </p> | |
| <p>This blocks computes the output <strong>y</strong> as <em>scalar product</em> of the two input vectors <strong>u1</strong> and <strong>u2</strong>: </p> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During development of our Modelica libraries, we centralize commonly used models and interfaces in the "DymolaModels" library, which is shipped with Dymola. Some of these models are so common that we want to give them back for the MSL.