Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSL 4.1.0 Regressions: set FundamentalWave..SymmetricPolyphaseWinding.ZeroInductor.i0 #4486

Merged
merged 3 commits into from
Oct 23, 2024
Merged

MSL 4.1.0 Regressions: set FundamentalWave..SymmetricPolyphaseWinding.ZeroInductor.i0 #4486

merged 3 commits into from
Oct 23, 2024

Conversation

AHaumer
Copy link
Contributor

@AHaumer AHaumer commented Oct 21, 2024

MSL 4.1.0 Regressions: set FundamentalWave..SymmetricPolyphaseWinding.ZeroInductor.i0(nominal=10) to avoid timeout during regression test (see #4333)

@AHaumer
MSL 4.1.0 Regressions: set FundamentalWave..SymmetricPolyphaseWinding…
e6c0adf 
….ZeroInductor.i0(nominal=10) to avoid timeout during regression test
@AHaumer AHaumer added bug Critical/severe issue L: Magnetic.FundamentalWave Issue addresses Modelica.Magnetic.FundamentalWave labels Oct 21, 2024
@AHaumer AHaumer added this to the MSL4.1.0 milestone Oct 21, 2024
@AHaumer AHaumer mentioned this pull request Oct 21, 2024
Open
11 tasks
christiankral
christiankral reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@christiankral christiankral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand, that changing the model Modelica/Magnetic/FundamentalWave/BasicMachines/Components/SymmetricPolyphaseWinding.mo is a simple solution as all example models inherit from it. Yet I wonder, if i0(nominal = 10) is a setting general enough to go to SymmetricPolyphaseWinding. Possibly this setting shall go to the affected examples.

@AHaumer
moved the modifier zeroInductor.i0(nominal=10) from Modelica/Magnetic…
633ad62 
…/FundamentalWave/BasicMachines/Components/SymmetricPolyphaseWinding 7to Modelica/Magnetic/FundamentalWave/Examples/BasicMachines/InductionMachines/IMC_YD
@AHaumer
Copy link
Contributor Author

AHaumer commented Oct 22, 2024 •
edited by christiankral
Loading

I understand, that changing the model Modelica/Magnetic/FundamentalWave/BasicMachines/Components/SymmetricPolyphaseWinding.mo is a simple solution as all example models inherit from it. Yet I wonder, if i0(nominal = 10) is a setting general enough to go to SymmetricPolyphaseWinding. Possibly this setting shall go to the affected examples.

ok done:
moved the modifier zeroInductor.i0(nominal=10) from Modelica/Magnetic/FundamentalWave/BasicMachines/Components/SymmetricPolyphaseWinding to Modelica/Magnetic/FundamentalWave/Examples/BasicMachines/InductionMachines/IMC_YD

christiankral
christiankral approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@christiankral christiankral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

maltelenz
maltelenz approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@maltelenz maltelenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine in System Modeler before and after.

@AHaumer AHaumer merged commit 7bc29a0 into modelica:master Oct 23, 2024
11 checks passed
@casella
Copy link
Contributor

casella commented Oct 24, 2024

@Esther-Devakirubai please back-port this to maint/4.1.x. Thanks!

@AHaumer when each of these issues is resolved on master, please remember to ask @Esther-Devakirubai to back-port it to the maintenance branch, otherwise the regression won't go away.

@beutlich beutlich added the V: 4.1.0-dev Issue originates in MSL v4.1.0-dev (and is not present in earlier releases) label Oct 27, 2024
@beutlich beutlich modified the milestones: MSL4.1.0, maintenance Oct 27, 2024
@beutlich beutlich mentioned this pull request Oct 27, 2024
Merged
@beutlich
Copy link
Member

please back-port this to maint/4.1.x.

See #4491.

@AHaumer
Copy link
Contributor Author

AHaumer commented Jan 21, 2025

Modelica.Magnetic.FundamentalWave.Examples.InductionMachines.IMC_YD works fine with this change og ZeroInductor in Dymola even with stricter Tolerance=1e-7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christiankral christiankral christiankral approved these changes

@maltelenz maltelenz maltelenz approved these changes

Assignees
No one assigned
Labels
bug Critical/severe issue L: Magnetic.FundamentalWave Issue addresses Modelica.Magnetic.FundamentalWave V: 4.1.0-dev Issue originates in MSL v4.1.0-dev (and is not present in earlier releases)
Projects
None yet
Milestone
maintenance
Development

Successfully merging this pull request may close these issues.
5 participants
@AHaumer @casella @beutlich @maltelenz @christiankral