-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version, uses annotation and copyright year #4247
Update version, uses annotation and copyright year #4247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes according to comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the copyright year in the license files
- LICENSE
- Modelica/Resources/Licenses/LICENSE_Modelica*.txt
also should get bumped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The C library's version also needs to be bumped: Modelica/Resources/BuildProjects/autotools/configure.ac
@beutlich @HansOlsson @maltelenz @henrikt-ma can you please review the changes . Thankyou |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A number of minor changes have been requested.
I think it would be good to first address the current comments, and then ask for a review. |
Removed version number as per comment modelica#4247 (comment)
Removed redundant version number info as per comment modelica#4247 (comment)
Dropped version number per comment in modelica#4247 (comment)
@beutlich @HansOlsson @henrikt-ma @maltelenz we have addressed the changes mentioned , can you please go through the changes. Thankyou |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Reverting the change for Mark, and deciding on dateModified isn't blocking
…autotools/configure.ac
Co-authored-by: Hans Olsson <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Hans Olsson <[email protected]>
Co-authored-by: Hans Olsson <[email protected]>
5f27f93
to
7ba0448
Compare
This PR updates all version and uses annotation to 4.1.0. It also updates copyright dates to 2024. Finally, it removes a spurious version annotation in a sub-package.