Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version, uses annotation and copyright year #4247

Merged
merged 34 commits into from
Jan 23, 2024

Conversation

casella
Copy link
Contributor

@casella casella commented Jan 10, 2024

This PR updates all version and uses annotation to 4.1.0. It also updates copyright dates to 2024. Finally, it removes a spurious version annotation in a sub-package.

Copy link
Contributor

@maltelenz maltelenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes according to comments.

Modelica/Electrical/Analog/UsersGuide/ReleaseNotes.mo Outdated Show resolved Hide resolved
Modelica/package.mo Outdated Show resolved Hide resolved
ModelicaTest/package.mo Outdated Show resolved Hide resolved
Modelica/package.mo Outdated Show resolved Hide resolved
ObsoleteModelica4.mo Outdated Show resolved Hide resolved
@beutlich beutlich added this to the MSL4.1.0 milestone Jan 10, 2024
Copy link
Member

@beutlich beutlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the copyright year in the license files

  • LICENSE
  • Modelica/Resources/Licenses/LICENSE_Modelica*.txt

also should get bumped.

Copy link
Member

@beutlich beutlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The C library's version also needs to be bumped: Modelica/Resources/BuildProjects/autotools/configure.ac

@beutlich beutlich changed the title Updated version and uses annotation, copyright dates Update version, uses annotation and copyright year Jan 10, 2024
ObsoleteModelica4.mo Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Jan 12, 2024

CLA assistant check
All committers have signed the CLA.

@Harisankar-Allimangalath
Copy link
Contributor

@beutlich @HansOlsson @maltelenz @henrikt-ma can you please review the changes . Thankyou

ObsoleteModelica4.mo Outdated Show resolved Hide resolved
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A number of minor changes have been requested.

@HansOlsson
Copy link
Contributor

@beutlich @HansOlsson @maltelenz @henrikt-ma can you please review the changes . Thankyou

I think it would be good to first address the current comments, and then ask for a review.

arunkumar-narasimhan added a commit to casella/ModelicaStandardLibrary that referenced this pull request Jan 12, 2024
arunkumar-narasimhan added a commit to casella/ModelicaStandardLibrary that referenced this pull request Jan 12, 2024
arunkumar-narasimhan added a commit to casella/ModelicaStandardLibrary that referenced this pull request Jan 12, 2024
Removed redundant version number info as per comment modelica#4247 (comment)
arunkumar-narasimhan added a commit to casella/ModelicaStandardLibrary that referenced this pull request Jan 12, 2024
Dropped version number per comment in modelica#4247 (comment)
Complex.mo Outdated Show resolved Hide resolved
@Harisankar-Allimangalath
Copy link
Contributor

@beutlich @HansOlsson @henrikt-ma @maltelenz we have addressed the changes mentioned , can you please go through the changes.

Thankyou

Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Reverting the change for Mark, and deciding on dateModified isn't blocking

Co-authored-by: Thomas Beutlich <[email protected]>
Co-authored-by: Thomas Beutlich <[email protected]>
@Harisankar-Allimangalath
Copy link
Contributor

@casella @beutlich , so we are planning to move ahead and branch out the maintenance and further procedures today itself .Do you have any suggestions over that ?

Thankyou

@Harisankar-Allimangalath Harisankar-Allimangalath merged commit b908927 into modelica:master Jan 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants