Simplify quoted identifier in text annotations #3593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r in the source. I believe this is as clear and it preserves the two important parts of the previous change: embedded space (required quoted identifier) and embedded } (more complicated quoting). It does not include a hierarchical name as that it is now explained separately. Should thus be merged after modelica#3592 Not needed, but I think it avoids issue.
HansOlsson
changed the title
|
An alternative to |
I have now used that. It will still have to merged with #3592, but together I think they make more sense. |
henrikt-ma
requested changes
Nov 5, 2024
Co-authored-by: Henrik Tidefelt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was confused by the previous text and almost thought it was an error.
Currently it says "( e.g.,
rec.'}'.'quoted ident')" and the proposed change is "( e.g.,'a}x'or'quoted ident')"I believe the rewrite is as clear and it preserves the two important parts of the previous change:
}(cannot simplify string parsing due to this).It does not include a hierarchical name as that it is now explained separately. Should thus be merged after #3592
Not needed, but I think it avoids my confusion and is clearer