Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Join two if branches with the same condition #295

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Join two if branches with the same condition #295

merged 1 commit into from
Nov 5, 2024

Conversation

jajik
Copy link
Collaborator

@jajik jajik commented Oct 30, 2024 •
edited
Loading

The route is not written to between the two ifs, so the condition must evaluate the same and is therefore useless to check twice.

@jajik jajik requested a review from jfclere October 30, 2024 13:05
rhusar
rhusar approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@rhusar rhusar merged commit c96ba2b into modcluster:main Nov 5, 2024
10 checks passed
@rhusar
Copy link
Member

rhusar commented Nov 5, 2024

Thanks @jajik @jfclere !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhusar rhusar rhusar approved these changes

@jfclere jfclere jfclere approved these changes

Assignees

@jfclere jfclere

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jajik @rhusar @jfclere