Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle resizing in pty-shell #2803

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Handle resizing in pty-shell #2803

wants to merge 1 commit into from

Conversation

azliu0
Copy link
Contributor

@azliu0 azliu0 commented Jan 24, 2025

Describe your changes

Very minor QoL improvement: support resizing the terminal window in pty-shell.

Implementation detail

It'd be cleaner to create the WindowSizeHandler inside of the ContainerProcess handle, but signal modifications must happen in the main thread / event loop. Synchronicity forces all apis wrapped in synchronize_api to execute in a different thread, hence the need to create WindowSizeHandler externally and pass it in as an arg to attach.

Server pr

Backward/forward compatibility checks

Check these boxes or delete any item (or this section) if not relevant for this PR.

  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.


Changelog

@azliu0 azliu0 force-pushed the azliu/pty-shell-resize branch 4 times, most recently from 23be5fd to 6786a06 Compare January 24, 2025 16:26
@azliu0 azliu0 force-pushed the azliu/pty-shell-resize branch from 6786a06 to f58a46e Compare January 24, 2025 16:27
@azliu0 azliu0 marked this pull request as draft January 24, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant