Merge pull request #69 from mod-posh/67-new-credential-cannot-process…

…-argument-transformation-on-parameter-password-cannot-convert-the-s3cretpssw0rd-value-of-type-systemstring-to-type-systemsecuritysecurestring issue-67: Update New-Credential function to accept string password
mod-posh · May 26, 2022 · 3031e9b · 3031e9b
2 parents 5094ebf + bbe1c1e
commit 3031e9b
Show file tree

Hide file tree

Showing 24 changed files with 2,273 additions and 57 deletions.
diff --git a/ComputerManagement/ComputerManagement-help.xml b/ComputerManagement/ComputerManagement-help.xml
diff --git a/ComputerManagement/ComputerManagement.psd1 b/ComputerManagement/ComputerManagement.psd1
@@ -1,9 +1,9 @@
 #
-# Module manifest for module 'PSGet_ComputerManagement'
+# Module manifest for module 'ComputerManagement'
 #
 # Generated by: Jeffrey Patton
 #
-# Generated on: 9/15/2020
+# Generated on: 5/26/2022
 #
 
 @{
@@ -12,7 +12,7 @@
 RootModule = 'ComputerManagement.psm1'
 
 # Version number of this module.
-ModuleVersion = '1.1.2.2'
+ModuleVersion = '1.1.2.3'
 
 # Supported PSEditions
 # CompatiblePSEditions = @()
@@ -32,20 +32,20 @@ Copyright = '9/12/2020 4:02:47 PM'
 # Description of the functionality provided by this module
 Description = 'A PowerShell module for working with the local computer'
 
-# Minimum version of the Windows PowerShell engine required by this module
+# Minimum version of the PowerShell engine required by this module
 # PowerShellVersion = ''
 
-# Name of the Windows PowerShell host required by this module
+# Name of the PowerShell host required by this module
 # PowerShellHostName = ''
 
-# Minimum version of the Windows PowerShell host required by this module
+# Minimum version of the PowerShell host required by this module
 # PowerShellHostVersion = ''
 
 # Minimum version of Microsoft .NET Framework required by this module. This prerequisite is valid for the PowerShell Desktop edition only.
 # DotNetFrameworkVersion = ''
 
 # Minimum version of the common language runtime (CLR) required by this module. This prerequisite is valid for the PowerShell Desktop edition only.
-# CLRVersion = ''
+# ClrVersion = ''
 
 # Processor architecture (None, X86, Amd64) required by this module
 # ProcessorArchitecture = ''
@@ -114,11 +114,17 @@ PrivateData = @{
         # ReleaseNotes of this module
         ReleaseNotes = 'https://github.com/mod-posh/ComputerManagement/blob/master/CHANGELOG.md'
 
+        # Prerelease string of this module
+        # Prerelease = ''
+
+        # Flag to indicate whether the module requires explicit user acceptance for install/update/save
+        # RequireLicenseAcceptance = $false
+
         # External dependent modules of this module
-        # ExternalModuleDependencies = ''
+        # ExternalModuleDependencies = @()
 
     } # End of PSData hashtable
-    
+
  } # End of PrivateData hashtable
 
 # HelpInfo URI of this module

diff --git a/ComputerManagement/ComputerManagement.psm1 b/ComputerManagement/ComputerManagement.psm1
@@ -638,14 +638,25 @@ function New-Credential {
     [Parameter(Mandatory = $true)]
     [string]$Username,
     [Parameter(Mandatory = $true)]
-    [securestring]$Password
+    $Password
   )
   begin {
 
   }
   process {
     if ($PSCmdlet.ShouldProcess("New", "New Credential")) {
-      New-Object System.Management.Automation.PSCredential ($Username, $Password)
+      switch ($Password.GetType().Name.ToLower()) {
+        'securestring' {
+          Write-Verbose "Found SecureString Password";
+          New-Object System.Management.Automation.PSCredential ($Username, $Password);
+        }
+        'string' {
+          Write-Verbose "Found String Password"
+          $SecureString = [System.Security.SecureString]::New();
+          $Password.ToCharArray() | Foreach-Object { $SecureString.AppendChar($_) };
+          New-Object System.Management.Automation.PSCredential ($Username, $SecureString);
+        }
+      }
     }
   }
   end {

diff --git a/README.md b/README.md
diff --git a/cabs/ComputerManagement_9c9c5339-5b88-4f63-a664-d9bf90b7ed3a_en-US_HelpContent.cab b/cabs/ComputerManagement_9c9c5339-5b88-4f63-a664-d9bf90b7ed3a_en-US_HelpContent.cab
diff --git a/cabs/ComputerManagement_9c9c5339-5b88-4f63-a664-d9bf90b7ed3a_en-US_HelpContent.zip b/cabs/ComputerManagement_9c9c5339-5b88-4f63-a664-d9bf90b7ed3a_en-US_HelpContent.zip
diff --git a/docs/Backup-EventLog.md b/docs/Backup-EventLog.md
@@ -32,7 +32,7 @@ Backup-EventLogs -ComputerName dc1
 The location to copy the logs to.
 
 ```yaml
-Type: String
+Type: System.String
 Parameter Sets: (All)
 Aliases:
 
@@ -47,7 +47,7 @@ Accept wildcard characters: False
 The NetBIOS name of the computer to connect to.
 
 ```yaml
-Type: String
+Type: System.String
 Parameter Sets: (All)
 Aliases:
 
@@ -63,7 +63,7 @@ The path to the logs you wish to backup. The default logpath
 "C:\Windows\system32\winevt\Logs" is used if left blank.
 
 ```yaml
-Type: String
+Type: System.String
 Parameter Sets: (All)
 Aliases:
 

diff --git a/docs/Connect-Rdp.md b/docs/Connect-Rdp.md
@@ -53,7 +53,7 @@ This example shows passing the computernames over the pipe
 The hostname or IP address of the computer to connect to
 
 ```yaml
-Type: Object
+Type: System.Object
 Parameter Sets: (All)
 Aliases:
 
@@ -69,7 +69,7 @@ A credential object that contains a valid username and password for
 the remote computer
 
 ```yaml
-Type: PSCredential
+Type: System.Management.Automation.PSCredential
 Parameter Sets: (All)
 Aliases:
 

diff --git a/docs/Export-EventLog.md b/docs/Export-EventLog.md
@@ -73,7 +73,7 @@ To get events and event logs from remote computers, the firewall port for
 the event log service must be configured to allow remote access.
 
 ```yaml
-Type: Object
+Type: System.Object
 Parameter Sets: (All)
 Aliases:
 
@@ -90,7 +90,7 @@ The
 default value is the current user.
 
 ```yaml
-Type: PSCredential
+Type: System.Management.Automation.PSCredential
 Parameter Sets: (All)
 Aliases:
 
@@ -105,7 +105,7 @@ Accept wildcard characters: False
 The full path and filename to where the log should be exported to.
 
 ```yaml
-Type: Object
+Type: System.Object
 Parameter Sets: (All)
 Aliases:
 
@@ -121,7 +121,7 @@ If present the function will list all the logs currently available on the
 computer.
 
 ```yaml
-Type: SwitchParameter
+Type: System.Management.Automation.SwitchParameter
 Parameter Sets: (All)
 Aliases:
 
@@ -136,7 +136,7 @@ Accept wildcard characters: False
 Export messages from the specified LogName
 
 ```yaml
-Type: Object
+Type: System.Object
 Parameter Sets: (All)
 Aliases:
 

diff --git a/docs/Get-DiskUsage.md b/docs/Get-DiskUsage.md
@@ -73,7 +73,7 @@ This example shows piping the output through Sort-Object
 The path to check
 
 ```yaml
-Type: String
+Type: System.String
 Parameter Sets: (All)
 Aliases:
 

diff --git a/docs/Get-InvalidLogonAttempt.md b/docs/Get-InvalidLogonAttempt.md
@@ -51,7 +51,7 @@ a csv file.
 The name of the computer to pull logs from
 
 ```yaml
-Type: Object
+Type: System.Object
 Parameter Sets: (All)
 Aliases:
 
@@ -71,7 +71,7 @@ entries.
 This can be modified to suit your needs.
 
 ```yaml
-Type: Object
+Type: System.Object
 Parameter Sets: (All)
 Aliases:
 
@@ -90,7 +90,7 @@ this particular script was designed to find a specific entry.
 This can be modified to suit your needs.
 
 ```yaml
-Type: Object
+Type: System.Object
 Parameter Sets: (All)
 Aliases:
 

diff --git a/docs/Get-MappedDrive.md b/docs/Get-MappedDrive.md
@@ -59,7 +59,7 @@ will be prompted.
 The name of the computer to get the list from.
 
 ```yaml
-Type: String
+Type: System.String
 Parameter Sets: (All)
 Aliases:
 
@@ -74,7 +74,7 @@ Accept wildcard characters: False
 A credentials object to pass if needed.
 
 ```yaml
-Type: PSCredential
+Type: System.Management.Automation.PSCredential
 Parameter Sets: (All)
 Aliases:
 

diff --git a/docs/Get-NetShare.md b/docs/Get-NetShare.md
@@ -41,7 +41,7 @@ This example shows the basic usage for this function
 The name of the server that has file or print shares
 
 ```yaml
-Type: String
+Type: System.String
 Parameter Sets: (All)
 Aliases:
 
@@ -58,7 +58,7 @@ This will be either Print or Disk
     Disk returns file shares
 
 ```yaml
-Type: String
+Type: System.String
 Parameter Sets: (All)
 Aliases:
 

diff --git a/docs/Get-NonStandardServiceAccount.md b/docs/Get-NonStandardServiceAccount.md
@@ -74,7 +74,7 @@ The back-tick (\`) was used for readability purposes only.
 The NetBIOS name of the computer to pull services from.
 
 ```yaml
-Type: String
+Type: System.String
 Parameter Sets: (All)
 Aliases:
 
@@ -89,7 +89,7 @@ Accept wildcard characters: False
 The DOMAIN\USERNAME of an account with permissions to access services.
 
 ```yaml
-Type: PSCredential
+Type: System.Management.Automation.PSCredential
 Parameter Sets: (All)
 Aliases:
 
@@ -104,7 +104,7 @@ Accept wildcard characters: False
 This is a pipe (|) seperated list of accounts to filter out of the returned services list.
 
 ```yaml
-Type: String
+Type: System.String
 Parameter Sets: (All)
 Aliases:
 

diff --git a/docs/Get-OpenFile.md b/docs/Get-OpenFile.md
@@ -42,7 +42,7 @@ This example shows the basic usage of this command.
 The NetBIOS or FQDN of the computer
 
 ```yaml
-Type: Object
+Type: System.Object
 Parameter Sets: (All)
 Aliases:
 

diff --git a/docs/Get-OpenSession.md b/docs/Get-OpenSession.md
@@ -42,7 +42,7 @@ This example shows the basic usage of the command.
 This is the FQDN or NetBIOS name of the computer
 
 ```yaml
-Type: Object
+Type: System.Object
 Parameter Sets: (All)
 Aliases:
 

diff --git a/docs/Get-PendingUpdate.md b/docs/Get-PendingUpdate.md
@@ -32,7 +32,7 @@ Get-PendingUpdates
 Computer or computers to find updates for.
 
 ```yaml
-Type: String
+Type: System.String
 Parameter Sets: (All)
 Aliases:
 

diff --git a/docs/Get-PrinterLog.md b/docs/Get-PrinterLog.md
@@ -52,7 +52,7 @@ This is the syntax that I would see being used the most.
 The name of your print server.
 
 ```yaml
-Type: Object
+Type: System.Object
 Parameter Sets: (All)
 Aliases:
 
@@ -67,7 +67,7 @@ Accept wildcard characters: False
 The default log for printing on Windows Server 2008 R2 is specified.
 
 ```yaml
-Type: Object
+Type: System.Object
 Parameter Sets: (All)
 Aliases:
 

diff --git a/docs/Get-RDPLoginEvent.md b/docs/Get-RDPLoginEvent.md
@@ -44,7 +44,7 @@ This example shows piping the output to Format-Table
 This is the NetBIOS name of the computer to pull events from.
 
 ```yaml
-Type: Object
+Type: System.Object
 Parameter Sets: (All)
 Aliases:
 
@@ -59,7 +59,7 @@ Accept wildcard characters: False
 A user account with the ability to retreive these events.
 
 ```yaml
-Type: PSCredential
+Type: System.Management.Automation.PSCredential
 Parameter Sets: (All)
 Aliases:
 

diff --git a/docs/Get-ServiceTag.md b/docs/Get-ServiceTag.md
@@ -36,7 +36,7 @@ SerialNumber
 The NetBIOS name of the computer.
 
 ```yaml
-Type: Object
+Type: System.Object
 Parameter Sets: (All)
 Aliases:
 

diff --git a/docs/Get-WinEventTail.md b/docs/Get-WinEventTail.md
@@ -44,7 +44,7 @@ TimeCreated                     Id LevelDisplayName Message
 Specify a valid Windows Eventlog name
 
 ```yaml
-Type: String
+Type: System.String
 Parameter Sets: (All)
 Aliases:
 
@@ -59,7 +59,7 @@ Accept wildcard characters: False
 An integer to show the number of events to start with, the default is 10
 
 ```yaml
-Type: Int32
+Type: System.Int32
 Parameter Sets: (All)
 Aliases: