test: fix npm scripts on windows

[mark-wiemer]

Closes #5220

Single quotes weren't resolved correctly on Windows. The single quotes don't seem necessary on any OS as they were never wrapping a space character.

Knip also reported prettier as unused, so I've added prettier to Knip's ignore list.

npm test is now passing on a clean install from on Windows, where it was failing before.

Ref https://github.com/mark-wiemer/mocha/pull/1 for status checks

[voxpelli]

This is a bit unintuitive to me – my impression is that the quotes should be there so that the js-based glob resolves rather than the shell glob 🤔

[mark-wiemer]

@voxpelli I'm not a glob expert, in my book if it works it works, but obviously if you don't feel comfortable merging that's fine. I'll dig deeper as obviously the tests are now failing on other operating* systems

[mark-wiemer]

Investigating remaining issues now, ref https://github.com/mark-wiemer/mocha/pull/1:

• ubuntu failure logs
• windows failure logs

[mark-wiemer]

I'm able to reproduce this issue locally with Node 22 on Windows, looks like the same err message. Going to see if different versions of 22.x work:

Full output

~/repos/mocha (mark-wiemer/lint)
$ fnm use 22
2024-09-29 10:35:59
Using Node v22.9.0
[last: 0s]
~/repos/mocha (mark-wiemer/lint)
$ npm run test-node:integration
2024-09-29 10:36:06

> [email protected] test-node:integration
> run-s clean build && npm run -s test-node-run -- --parallel --timeout 10000 --slow 3750 "test/integration/plugins/root-hooks.spec.js"


> [email protected] clean
> rimraf mocha.js mocha.js.map


> [email protected] build
> rollup -c ./rollup.config.js


./browser-entry.js → ./mocha.js...
created ./mocha.js in 1.9s


  root hooks
    when mocha run in serial mode
      ✔ should run root hooks when provided via mochaHooks object export
      ✔ should run root hooks when provided via mochaHooks function export
      support ESM when type=module or .mjs extension
        ✔ should run root hooks when provided via mochaHooks
      support ESM via .js extension w/o type=module
        1) should fail due to ambiguous file type
    when mocha in parallel mode
      ✔ should run root hooks when provided via mochaHooks object exports
      ✔ should run root hooks when provided via mochaHooks function export
      when running multiple jobs
        ✔ should run root hooks when provided via mochaHooks object exports for each job


  6 passing (9s)
  1 failing

  1) root hooks
       when mocha run in serial mode
         support ESM via .js extension w/o type=module
           should fail due to ambiguous file type:
     
expected Promise when fulfilled to contain output /SyntaxError: Unexpected token/
  expected
  {
    output: '\n✖ \x1b[31mERROR:\x1b[39m Error [ERR_REQUIRE_CYCLE_MODULE]: Cannot require() ES Module C:\\Users\\markw\\repos\\mocha\\test\\integration\\fixtures\\plugins\\root-hooks\\root-hook-defs-esm-broken.fixture.js in a cycle.\n    at ModuleLoader.importSyncForRequire (node:internal/modules/esm/loader:303:15)\n    at loadESMFromCJS (node:internal/modules/cjs/loader:1381:24)\n    at Module._compile (node:internal/modules/cjs/loader:1503:5)\n    at Module.replacementCompile (C:\\Users\\markw\\repos\\mocha\\node_modules\\append-transform\\index.js:60:13)\n    at Module._extensions..js (node:internal/modules/cjs/loader:1691:10)\n    at Object.<anonymous> (C:\\Users\\markw\\repos\\mocha\\node_modules\\append-transform\\index.js:64:4)\n    at Module.load (node:internal/modules/cjs/loader:1317:32)\n    at Module._load (node:internal/modules/cjs/loader:1127:12)\n    at TracingChannel.traceSync (node:diagnostics_channel:315:14)\n    at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)\n    at cjsLoader (node:internal/modules/esm/translators:329:5)\n    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:260:7)\n    at ModuleJob.run (node:internal/modules/esm/module_job:262:25)\n    at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:483:26)\n    at async formattedImport (C:\\Users\\markw\\repos\\mocha\\lib\\nodejs\\esm-utils.js:2:567)\n    at async exports.requireOrImport (C:\\Users\\markw\\repos\\mocha\\lib\\nodejs\\esm-utils.js:7:1135)\n    at async exports.handleRequires (C:\\Users\\markw\\repos\\mocha\\lib\\cli\\run-helpers.js:38:364)\n    at async C:\\Users\\markw\\repos\\mocha\\lib\\cli\\run.js:18:40 {\n  code: \'ERR_REQUIRE_CYCLE_MODULE\'\n}\n',
    code: 1,
    args: [
      'C:\\Users\\markw\\repos\\mocha\\bin\\mocha.js',
      '--require=C:\\Users\\markw\\repos\\mocha\\test\\integration\\fixtures\\plugins\\root-hooks\\root-hook-defs-esm-broken.fixture.js',
      '--no-color',
      '--no-bail',
      '--no-parallel'
    ],
    command: 'C:\\Users\\markw\\repos\\mocha\\bin\\mocha.js --require=C:\\Users\\markw\\repos\\mocha\\test\\integration\\fixtures\\plugins\\root-hooks\\root-hook-defs-esm-broken.fixture.js --no-color --no-bail --no-parallel'
  }
  to contain output /SyntaxError: Unexpected token/


  expected Promise when fulfilled to contain output /SyntaxError: Unexpected token/
    expected
    {
      output: '\n✖ \x1b[31mERROR:\x1b[39m Error [ERR_REQUIRE_CYCLE_MODULE]: Cannot require() ES Module C:\\Users\\markw\\repos\\mocha\\test\\integration\\fixtures\\plugins\\root-hooks\\root-hook-defs-esm-broken.fixture.js in a cycle.\n    at ModuleLoader.importSyncForRequire (node:internal/modules/esm/loader:303:15)\n    at loadESMFromCJS (node:internal/modules/cjs/loader:1381:24)\n    at Module._compile (node:internal/modules/cjs/loader:1503:5)\n    at Module.replacementCompile (C:\\Users\\markw\\repos\\mocha\\node_modules\\append-transform\\index.js:60:13)\n    at Module._extensions..js (node:internal/modules/cjs/loader:1691:10)\n    at Object.<anonymous> (C:\\Users\\markw\\repos\\mocha\\node_modules\\append-transform\\index.js:64:4)\n    at Module.load (node:internal/modules/cjs/loader:1317:32)\n    at Module._load (node:internal/modules/cjs/loader:1127:12)\n    at TracingChannel.traceSync (node:diagnostics_channel:315:14)\n    at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)\n    at cjsLoader (node:internal/modules/esm/translators:329:5)\n    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:260:7)\n    at ModuleJob.run (node:internal/modules/esm/module_job:262:25)\n    at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:483:26)\n    at async formattedImport (C:\\Users\\markw\\repos\\mocha\\lib\\nodejs\\esm-utils.js:2:567)\n    at async exports.requireOrImport (C:\\Users\\markw\\repos\\mocha\\lib\\nodejs\\esm-utils.js:7:1135)\n    at async exports.handleRequires (C:\\Users\\markw\\repos\\mocha\\lib\\cli\\run-helpers.js:38:364)\n    at async C:\\Users\\markw\\repos\\mocha\\lib\\cli\\run.js:18:40 {\n  code: \'ERR_REQUIRE_CYCLE_MODULE\'\n}\n',
      code: 1,
      args: [
        '--require=C:\\Users\\markw\\repos\\mocha\\test\\integration\\fixtures\\plugins\\root-hooks\\root-hook-defs-esm-broken.fixture.js',
        '--no-color',
        '--no-bail',
        '--no-parallel'
      ],
    }
    to contain output /SyntaxError: Unexpected token/
      at Array.forEach (<anonymous>)
  From previous event:
      at Context.<anonymous> (test\integration\plugins\root-hooks.spec.js:140:16)
      at callFn (lib\runnable.js:110:584)
      at Runnable.run (lib\runnable.js:110:57)
      at Runner.runTest (lib\runner.js:182:1054)
      at C:\Users\markw\repos\mocha\lib\runner.js:210:654
      at next (lib\runner.js:159:422)
      at C:\Users\markw\repos\mocha\lib\runner.js:159:809
      at next (lib\runner.js:147:579)
      at Immediate.<anonymous> (lib\runner.js:151:1253)
      at process.processImmediate (node:internal/timers:491:21)
      set UNEXPECTED_FULL_TRACE=true to see the full stack trace



[last: 27s]

[mark-wiemer]

• Last good node: 22.6.0
• First bad node: 22.7.0

[mark-wiemer]

Added tests to distinguish between --no-experimental-module-detection and --experimental-module-detection as the latter is the default in Node 22.7 and later

[voxpelli]

Looks good to me! Thanks 🙏

Extra thanks for fixing the tests for latest Node version!