Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add knip to validate included dependencies #5042

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

voxpelli
Copy link
Member

@voxpelli voxpelli commented Dec 5, 2023

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions.

Description of the Change

Alternate Designs

Why should this be in core?

Benefits

Possible Drawbacks

Applicable issues

@voxpelli
Copy link
Member Author

voxpelli commented Dec 5, 2023

Thoughts:

That leaves this PR doing only knip, which is good, and we can rebase it until it passes and when it passes we can merge it 🎉

@voxpelli
Copy link
Member Author

voxpelli commented Dec 5, 2023

Still eg. complains on:

@11ty/eleventy         package.json
@mocha/docdash         package.json
assetgraph-builder     package.json
autoprefixer           package.json
canvas                 package.json
coffeescript           package.json
coveralls              package.json
eslint-plugin-node     package.json
husky                  package.json
hyperlink              package.json
jsdoc                  package.json
jsdoc-ts-utils         package.json
karma-chrome-launcher  package.json
karma-sauce-launcher   package.json
markdown-toc           package.json
needle                 package.json
nyc                    package.json
strip-ansi             package.json
svgo                   package.json
update-notifier        package.json
webpack-cli            package.json

@voxpelli voxpelli force-pushed the voxpelli/issue5041 branch from 93a535f to 150c5c9 Compare August 5, 2024 13:12
@voxpelli voxpelli changed the title Look into adding Knip chore: add knip to validate included dependencies Aug 5, 2024
@voxpelli voxpelli added status: needs review a maintainer should (re-)review this pull request and removed status: waiting for author waiting on response from OP - more information needed labels Aug 5, 2024
@voxpelli voxpelli self-assigned this Aug 5, 2024
@voxpelli voxpelli requested a review from a team August 5, 2024 13:15
@voxpelli voxpelli marked this pull request as ready for review August 5, 2024 13:15
@voxpelli
Copy link
Member Author

voxpelli commented Aug 5, 2024

This is ready now as well, after the merge of #5128

@coveralls
Copy link

Coverage Status

coverage: 94.495% (-0.002%) from 94.497%
when pulling 150c5c9 on voxpelli/issue5041
into c44653a on main.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 let's ship it!

@JoshuaKGoldberg JoshuaKGoldberg removed the status: needs review a maintainer should (re-)review this pull request label Aug 6, 2024
@voxpelli voxpelli merged commit 5c2989f into main Aug 6, 2024
109 checks passed
@voxpelli voxpelli deleted the voxpelli/issue5041 branch August 6, 2024 14:52
voxpelli added a commit to voxpelli/knip that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants