Remove the old shutdown protocol #424
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we multiplexed all port forwards over one connection, we had to layer our own custom shutdown protocol on top to work around Hyper-V socket bugs. This is not needed any more because the same work is done within the multiplexing protocol. Note this requires an updated vpnkit-forwarder. Signed-off-by: David Scott <[email protected]>
This removes the legacy shutdown protocol. Signed-off-by: David Scott <[email protected]>
Signed-off-by: David Scott <[email protected]>
Signed-off-by: David Scott <[email protected]>
Signed-off-by: David Scott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old protocol was needed to work around Hyper-V socket bugs, where data would be lost after a
shutdown. This is no longer needed because the new multiplexing protocol doesn't callshutdown, since it multiplexes all port forwarding connections over a single connection.This supercedes #418